resolvconf.conf.5.in: multiple-entries name_servers syntax #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarify the syntax to be used to specify multiple name servers in a name_servers directive.
rsmarples
requested changes
Jan 16, 2025
There was a problem hiding this comment.
name_servers isn't special with this, so I reject the change.
The DESCRIPTION section says this:
The resolvconf.conf file is a shell script that is sourced by resolvconf(8),
meaning that resolvconf.conf must contain valid shell commands. Listed
below are the standard resolvconf.conf variables that may be set. If the
values contain whitespace, wildcards or other special shell characters,
ensure they are quoted and escaped correctly. See the replace variable
for an example on quoting.
Maybe it needs an extra sentence just before the end:
Multiple values should be space separated and quoted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify the syntax to be used to specify multiple name servers in a name_servers directive.
Close #31