Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contact Us 페이지의 인스타그램 URL 노출 #39

Open
delphox60 opened this issue Oct 30, 2023 · 0 comments · May be fixed by #40
Open

Contact Us 페이지의 인스타그램 URL 노출 #39

delphox60 opened this issue Oct 30, 2023 · 0 comments · May be fixed by #40
Assignees
@delphox60

Comments

@delphox60
Copy link
Member

개요

instagram의 contact-box 만 text 값에 URL이 들어가 있어 미관상 좋지 않은 이슈입니다.
PC 버전의 경우 위화감을 주는 데에서 그칠 수 있지만, 모바일의 경우에는 "Instagram" 문구와 URL이 붙어 있어 미관상 매우 좋지 않아 수정이 필요해 보입니다.

스크린샷 2023-10-30 오후 5 48 29

원인

해당 텍스트가 시트를 통한 반영이 아닌, 소스 코드 내에 URL로 하드코딩되어 있습니다. (#38)
delphox60 added a commit that referenced this issue Oct 30, 2023
@delphox60
fix(contact): change instagram URL into ID (#39)
3ca6826
@delphox60 delphox60 linked a pull request Oct 30, 2023 that will close this issue
Open
@delphox60 delphox60 linked a pull request Oct 30, 2023 that will close this issue
fix(contact): change instagram URL into ID (#39) #40
Open
@delphox60 delphox60 self-assigned this Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@delphox60 delphox60

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(contact): change instagram URL into ID (#39) Nexters/teamnexters.com
1 participant
@delphox60