Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruff 0.9.2: Build fails during checkPhase #375305

Closed
3 tasks done
TouriM opened this issue Jan 20, 2025 · 3 comments
Closed
3 tasks done

Ruff 0.9.2: Build fails during checkPhase #375305

TouriM opened this issue Jan 20, 2025 · 3 comments
Labels
0.kind: bug Something is broken 6.topic: darwin Running or building packages on Darwin

Comments

@TouriM
Copy link

TouriM commented Jan 20, 2025

Nixpkgs version

  • Unstable (25.05)

Describe the bug

When building ruff 0.9.2 the build fails during checkPhase with:

Running tests/fixtures/main.rs (target/aarch64-apple-darwin/debug/deps/fixtures-e8e11b634bb8a8d8)
error: unexpected argument '--skip=added_package' found

This is part of the ruff_annotate_snippets test.

I believe that this is "Darwin" only problem, as '--skip=added_package' is only set on Darwin. I also noticed that the two Darwin specific Tests are still queued (for the past 3 days):
https://github.com/NixOS/nixpkgs/runs/35724914850
OfBorg / ruff, ruff.passthru.tests on x86_64-darwin
OfBorg / ruff, ruff.passthru.tests on aarch64-darwin

Steps to reproduce

Just add the pkgs.ruff to Darwin setup.

Expected behaviour

ruff should build

Screenshots

No response

Relevant log output

error: unexpected argument '--skip=added_package' found

Usage: fixtures-e8e11b634bb8a8d8 [OPTIONS] [FILTER]

For more information, try '--help'.
error: test failed, to rerun pass `-p ruff_annotate_snippets --test fixtures`

Caused by:
  process didn't exit successfully: `/private/tmp/nix-build-ruff-0.9.2.drv-0/source/target/aarch64-apple-darwin/debug/deps/fixtures-e8e11b634bb8a8d8 --test-threads=14 -- --test-threads=14 --skip=added_package --s

Additional context

No response

System metadata

  • system: "aarch64-darwin"
  • host os: Darwin 24.1.0, macOS 15.1.1
  • multi-user?: yes
  • sandbox: no
  • version: nix-env (Nix) 2.24.11
  • nixpkgs: /nix/store/gsglmw72a60s328zs3n32i2s5q9yadxb-source

Are you using nix-darwin?

Yes, I am using nix-darwin.

Notify maintainers

@figsoda
@GaetanLepage

Note for maintainers: Please tag this issue in your pull request description. (i.e. Resolves #ISSUE.)

I assert that this issue is relevant for Nixpkgs

Is this issue important to you?

Add a 👍 reaction to issues you find important.

@TouriM TouriM added 0.kind: bug Something is broken 6.topic: darwin Running or building packages on Darwin labels Jan 20, 2025
@TouriM TouriM changed the title Ruff 0.9.2: Build fails on checkPhase Ruff 0.9.2: Build fails during checkPhase Jan 20, 2025
@GaetanLepage
Copy link
Contributor

Thanks for reporting. This has been fixed in #374697.

You can follow its progress towards the unstable channels here: https://nixpkgs-tracker.ocfox.me/?pr=374697.

@Mic92
Copy link
Member

Mic92 commented Jan 20, 2025

Closed because of #374697

@Mic92 Mic92 closed this as completed Jan 20, 2025
@TouriM
Copy link
Author

TouriM commented Jan 20, 2025

@GaetanLepage thanks for your work!
In the future I'll check the pull requests as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: bug Something is broken 6.topic: darwin Running or building packages on Darwin
Projects
None yet
Development

No branches or pull requests

3 participants