You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Bug: Importing Routes in MDT Doesn't Update Existing Routes
Description
When importing a route in the Mythic Dungeon Tools (MDT) addon, it never prompts to update an existing route if the route already exists. Instead, it imports the route as a new one every time.
Steps to Reproduce
Import a route in MDT.
Attempt to import the same route again.
Notice that instead of updating the existing route, a new duplicate route is created.
Expected Behavior
If a route already exists with the same name or unique identifier (UID), MDT should prompt to update the existing route rather than importing it as a new one.
Actual Behavior
MDT always imports the route as a new one, even if a duplicate route exists.
Cause
The issue seems to stem from the following code blocks in MythicDungeonTools.lua and Modules/Transmission.lua:
This logic always assigns a new unique ID (uid) during the first import. As a result, subsequent imports can never find a duplicate in the following check in MDT:ImportPreset():
Bug: Importing Routes in MDT Doesn't Update Existing Routes
Description
When importing a route in the Mythic Dungeon Tools (MDT) addon, it never prompts to update an existing route if the route already exists. Instead, it imports the route as a new one every time.
Steps to Reproduce
Expected Behavior
If a route already exists with the same name or unique identifier (UID), MDT should prompt to update the existing route rather than importing it as a new one.
Actual Behavior
MDT always imports the route as a new one, even if a duplicate route exists.
Cause
The issue seems to stem from the following code blocks in
MythicDungeonTools.lua
andModules/Transmission.lua
:MythicDungeonTools/MythicDungeonTools.lua
Lines 3057 to 3062 in 2a08c91
MythicDungeonTools/Modules/Transmission.lua
Lines 767 to 787 in 2a08c91
This logic always assigns a new unique ID (
uid
) during the first import. As a result, subsequent imports can never find a duplicate in the following check inMDT:ImportPreset()
:MythicDungeonTools/MythicDungeonTools.lua
Lines 3017 to 3023 in 2a08c91
Because a new
uid
is assigned, the duplicate detection mechanism fails, and the route is treated as a new one rather than updating the existing one.Suggested Fix
Consider adjusting the logic to retain the
uid
when importing, so that subsequent imports can correctly identify and update the existing route.Additional Information
The text was updated successfully, but these errors were encountered: