Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missleading name #14

Open
markotron opened this issue Feb 5, 2019 · 2 comments
Open

Missleading name #14

markotron opened this issue Feb 5, 2019 · 2 comments

Comments

@markotron
Copy link
Contributor

fun <Element> _Template_<Element>.doOnSubscribed(onSubscribed: () -> Unit): _Template_<Element> =

When we share a sequence this will actually be called only once. Not multiple times. as you would expect.

@kzaher
Copy link
Member

kzaher commented Feb 6, 2019 via email

@markotron
Copy link
Contributor Author

I mean:

val driver = myDriver
   .doOnSubscribed { println("test") } 

driver.subscribe() // prints test
driver.subscribe() // doesn't print test

My thought was that this is misleading so I wanted to open the issue and discuss.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants