Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move _noty plugin core with option to disable #2743

Open
stickz opened this issue Oct 16, 2024 · 3 comments
Open

Move _noty plugin core with option to disable #2743

stickz opened this issue Oct 16, 2024 · 3 comments

Comments

@stickz
Copy link
Collaborator

stickz commented Oct 16, 2024

What would you like changed about the web client?

The _noty plugin which injects jquery.noty.js into the web interface is causing a painful impact to loading times.

Describe the solution you'd like and propose possible alternatives.

I purpose to bring this functionality to the core web interface (instead of a plugin implementation) and create a control to disable it.

Provide information and resources about the environment hosting the web client.

Server: ruTorrent v5.1-Beta2 on Ubuntu 24.04 LTS
Web Client: Google Chrome 129.0.6668.59
Installation Method: zip source from version release

Additional context

No response

@jevenski
Copy link
Contributor

Bootstrap has a Toast module. We can use it to implement the notification feature, and replace the _noty and _noty2 plugins.

@stickz
Copy link
Collaborator Author

stickz commented Oct 31, 2024

Bootstrap has a Toast module. We can use it to implement the notification feature, and replace the _noty and _noty2 plugins.

I disagree with replacing notifications. This would be a massive undertaking. It easier to just move them to core. The biggest issue is them loading as part of a plugin. It's appending content to the DOM instead of just loading in index.html all at once. IMHO, all the jQuery modules required should be in core and initialized as required. This makes sense from a project perspective.

@jevenski
Copy link
Contributor

jevenski commented Nov 1, 2024

The amount of work won't be anywhere near that of the work we have done in rewriting the project for responsiveness. Add some Bootstrap class names to the elements, and apply a few Bootstrap JavaScript methods if necessary, the rest will be taken care of by Bootstrap itself. The functionality is implemented by Bootstrap internally, so we don't need jQuery noty plugin or reinventing the wheels ourselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants