Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab behaviour is weird in the editor #247

Open
scutoid-bkr opened this issue Feb 18, 2024 · 3 comments
Open

Tab behaviour is weird in the editor #247

scutoid-bkr opened this issue Feb 18, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@scutoid-bkr
Copy link

Describe the issue:
The ordering of the editor icons is done with grid areas which does provide a nicely organized editor, but this does have the problem of confusing tab navigation.

Screenshot showcasing the issue:
ezgif-4-0a1ba65d5e

Link to the page(s) having this issue:
N/A

Device information: (fill in as appropriate)

  • Device: Thinkpad T460p
  • OS: Debian 13 (testing)
  • Browser: Firefox
  • Version: mozilla deb repo 122.0.1

Additional context:
I guess this is just where you pick your poison because the organization of the items is a nice feature, but this theme seems generally concerned with a good tab navigation experience so it might be better to organize them by their order in the html.

@scutoid-bkr scutoid-bkr added the bug Something isn't working label Feb 18, 2024
@Woedenaz
Copy link
Contributor

You are correct in the additional context.

I am unsure how I feel about this. I personally prefer them being grouped visually in an order that makes logical sense but I know it causes this odd tab navigation behavior as well.

This is definitely a case where I desperately wish I had the ability to edit the HTML because the original grouping of the buttons is complete nonsense.

@scutoid-bkr
Copy link
Author

it sure is, but this is a pretty big accessibility problem. it's pretty sad because the current editor grouping is beautiful, but this might be project foundation territory lol. given that black highlighter has taken strides to improve tab navigation issues present in sigma-9 i think it should definitely have a good tab experience in the editor, though.

if it's any consolation, the editor experience in all other ways is drastically improved compared to the base wikidot style.

@Woedenaz
Copy link
Contributor

I appreciate that!

I certainly agree and you make a very compelling point. Give me a few more days to mull it over and I'll make a decision! Genuinely thank you for the insightful feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants