Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][ADD] website_sale_partner_restrict_payment_acquirer: New module website_sale_partner_restrict_payment_acquirer #1021

Merged
merged 1 commit into from
Feb 20, 2025
Merged

[15.0][ADD] website_sale_partner_restrict_payment_acquirer: New module website_sale_partner_restrict_payment_acquirer #1021

merged 1 commit into from
Feb 20, 2025

Conversation

ppyczko
Copy link

@ppyczko ppyczko commented Feb 12, 2025 •
edited
Loading

This module extends the functionality of partner_restrict_payment_acquirer to restrict payment acquirers for a partner during the checkout process in e-commerce. Only the selected acquirers will be available for online payments.

cc https://github.com/APSL 166715

@miquelalzanillas @lbarry-apsl @mpascuall @peluko00 @javierobcn @BernatObrador please review

Depends on:

@ppyczko ppyczko force-pushed the 15.0-add-website_sale_partner_restrict_payment_acquirer branch from 353bf70 to 9d2c376 Compare February 12, 2025 08:13
@ppyczko ppyczko marked this pull request as ready for review February 12, 2025 08:26
peluko00
peluko00 approved these changes Feb 12, 2025
View reviewed changes
Copy link

@peluko00 peluko00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in runboat

mpascuall
mpascuall approved these changes Feb 12, 2025
View reviewed changes
Copy link

@mpascuall mpascuall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in runboat

@ppyczko ppyczko force-pushed the 15.0-add-website_sale_partner_restrict_payment_acquirer branch from 9d2c376 to 91178f8 Compare February 17, 2025 13:06
@ppyczko
Copy link
Author

ppyczko commented Feb 17, 2025

Hi @ivs-cetmix, sorry to ping directly. Could you also review this PR when you have a moment please? It's related to the [15.0][MIG] partner_restrict_payment_acquirer PR. Thank you in advance!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

lbarry-apsl
lbarry-apsl approved these changes Feb 18, 2025
View reviewed changes
Copy link
Member

@lbarry-apsl lbarry-apsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed code and runbot, LGTM

ivs-cetmix
ivs-cetmix suggested changes Feb 18, 2025
View reviewed changes
Copy link
Member

@ivs-cetmix ivs-cetmix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also highly recommend to add screenshots to make the documentation more user friendly. Please use images no more than 800px wide so they would be displayed correctly in the Odoo App Store.

@ppyczko ppyczko force-pushed the 15.0-add-website_sale_partner_restrict_payment_acquirer branch 5 times, most recently from 53cc55b to 8bf0f47 Compare February 19, 2025 08:02
@ppyczko
[15.0][ADD] website_sale_partner_restrict_payment_acquirer: New modul…
29a259f 
…e website_sale_partner_restrict_payment_acquirer
@ppyczko ppyczko force-pushed the 15.0-add-website_sale_partner_restrict_payment_acquirer branch from 8bf0f47 to 29a259f Compare February 19, 2025 08:06
ivs-cetmix
ivs-cetmix approved these changes Feb 19, 2025
View reviewed changes
Copy link
Member

@ivs-cetmix ivs-cetmix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@ppyczko
Copy link
Author

ppyczko commented Feb 20, 2025

Hi @pedrobaeza, is this ready to be merged? Thank you!

@pedrobaeza
Copy link
Member

Merging due to the existing reviews:

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-1021-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 369e273. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit 9910738 into OCA:15.0 Feb 20, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivs-cetmix ivs-cetmix ivs-cetmix approved these changes

@lbarry-apsl lbarry-apsl lbarry-apsl approved these changes

@peluko00 peluko00 peluko00 approved these changes

@mpascuall mpascuall mpascuall approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ppyczko @OCA-git-bot @pedrobaeza @ivs-cetmix @lbarry-apsl @peluko00 @mpascuall