[16.0][IMP] website_sale_product_assortment: Fix the behavior of the website's search function for product assortments. #1023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @CarlosRoca13, |
SuShanVoong
force-pushed
the
16.0-imp-website_sale_product_assortment
branch
2 times, most recently
from
5f3354c to
1b4f715
Compare
|
Before the changes, the search engine displayed products that were not selected in the assortment. Grabacion.de.pantalla.desde.2025-02-17.14-07-21.webmNow it is fixed. Grabacion.de.pantalla.desde.2025-02-17.14-34-17.webm |
SuShanVoong
force-pushed
the
16.0-imp-website_sale_product_assortment
branch
from
1b4f715 to
7e9186b
Compare
danielduqma
approved these changes
Feb 17, 2025
There was a problem hiding this comment.
Thanks @SuShanVoong, tested functionally and everything works as expected!
SuShanVoong
force-pushed
the
16.0-imp-website_sale_product_assortment
branch
from
7e9186b to
5859df7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
An issue has been identified in the website's search behavior related to the visibility settings for unavailable products. Despite having the "Avoid to show non avaible product" option enabled, unavailable products were still appearing in search results. This caused an inconsistent user experience, as attempting to access an unavailable product resulted in a "Page not found" error.
Cases Covered with This Improvement:
Implemented Solution:
To resolve this issue, modifications were made to the search
autocompletemethod, implementing.website_salefromWebsiteSaleinmain.pyso that the_get_products_allowedmethod can be used.The
allowed_product_domainparameter was added to theoptions, allowing the availability restriction to be properly applied when executing the_search_get_detailfunction.This ensures that unavailable products are filtered out before appearing in search results, guaranteeing that the user's selected configuration is correctly enforced.
FL-556-5220