-
-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] website_sale_vat_required: Migration to version 18.0 #1029
Open
carlos-lopez-tecnativa
wants to merge
20
commits into
OCA:18.0
Choose a base branch
from
Tecnativa:18.0-mig-website_sale_vat_required
base: 18.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[18.0][MIG] website_sale_vat_required: Migration to version 18.0 #1029
carlos-lopez-tecnativa
wants to merge
20
commits into
OCA:18.0
from
Tecnativa:18.0-mig-website_sale_vat_required
+770
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[FIX] Depend on vat validation module that causes the VAT number field to be displayed at checkout in the first place
This addon got migrated from 8.0. Relevant notes: - Moved from `OCA/website` to `OCA/e-commerce`. - Reduced license headers to new style ones, keeping copyright. - Updated README template. - Replaced dirty hack that disables addon in test mode, and hack the tour instead (actually testing the addon). - Benefit from upstream updates, that now handles incorrect VAT errors.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: e-commerce-12.0/e-commerce-12.0-website_sale_vat_required Translate-URL: https://translation.odoo-community.org/projects/e-commerce-12-0/e-commerce-12-0-website_sale_vat_required/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: e-commerce-13.0/e-commerce-13.0-website_sale_vat_required Translate-URL: https://translation.odoo-community.org/projects/e-commerce-13-0/e-commerce-13-0-website_sale_vat_required/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: e-commerce-15.0/e-commerce-15.0-website_sale_vat_required Translate-URL: https://translation.odoo-community.org/projects/e-commerce-15-0/e-commerce-15-0-website_sale_vat_required/
…hods in test Modify the tests so that we don't have to rely on the payment methods module to run the tests for the functionality of this module. TT44388
The tests were using a demo data product so if at any time this product does not exist the tests start to fail. To avoid this, a new product is created and used for testing. Also to locate the checkout button it is better to locate it by its container element as the classes can change depending on the configuration and modules used in the instance and it can be a problem to locate it.
Adapt according to this commit: odoo/odoo@453cfab
/ocabot migration website_sale_vat_required |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt according to this commit: odoo/odoo@453cfab
TT54540
@Tecnativa @pedrobaeza @CarlosRoca13 @pilarvargas-tecnativa could you please review this?