[16.0][FIX] hr_holidays_public: keep 'employee_id' field amongst method calls #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiquelRForgeFlow
approved these changes
Feb 10, 2025
GuillemCForgeFlow
approved these changes
Feb 11, 2025
|
This PR has the |
|
ping @OCA/human-resources-maintainers |
|
/ocabot merge patch |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at bf3846d. Thanks a lot for contributing to OCA. ❤️ |
MiquelRForgeFlow
deleted the
16.0-fix-hr_holidays_public-keep_employee_id
branch
|
Please, forward port. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, the
employee_id's parameter value was lost when calling some functions from other ones in this module (for example, when calling_get_domain_states_filterfromget_holidays_list.However, this parameter might be necessary in the computation of some holidays, when having restrictions related to the employee, instead of the partner (accessed through
employee.address_id). You can see an example of that in the module added in #161.