Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FWPORT][18.0][IMP] l10n_fr_siret: improve data migration script #631

Open
wants to merge 1 commit into
base: 18.0
Choose a base branch
from
Open

[FWPORT][18.0][IMP] l10n_fr_siret: improve data migration script #631

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 23 additions & 6 deletions l10n_fr_siret/post_install.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,25 +5,42 @@

import logging

from stdnum.fr.siret import is_valid
from stdnum.fr.siren import is_valid as siren_is_valid
from stdnum.fr.siret import is_valid as siret_is_valid

logger = logging.getLogger(__name__)


def set_siren_nic(env):
logger.info("Starting data migration of fields siret/siren/nic on res.partner")
partners = (
env["res.partner"]
.with_context(active_test=False)
.search([("siret", "!=", False), ("parent_id", "=", False)])
)
for partner in partners:
if is_valid(partner.siret):
logger.info("Setting SIREN and NIC on partner %s", partner.display_name)
partner.write({"siret": partner.siret})
ini_siret = partner.siret.replace(" ", "")
if len(ini_siret) == 14 and siret_is_valid(ini_siret):
logger.debug("Setting SIREN and NIC on partner %s", partner.display_name)
partner.write({"siret": ini_siret})
elif len(ini_siret) == 9 and siren_is_valid(ini_siret):
logger.debug("Setting SIREN on partner %s", partner.display_name)
partner.write({"siren": ini_siret})

Check warning on line 28 in l10n_fr_siret/post_install.py

View check run for this annotation

Codecov / codecov/patch

l10n_fr_siret/post_install.py#L27-L28 

Added lines #L27 - L28 were not covered by tests
elif len(ini_siret) > 9 and siren_is_valid(ini_siret[:9]):
logger.info(

Check warning on line 30 in l10n_fr_siret/post_install.py

View check run for this annotation

Codecov / codecov/patch

l10n_fr_siret/post_install.py#L30 

Added line #L30 was not covered by tests
"Setting SIREN %s on partner %s. Wrong additional chars ignored "
"(bad initial SIRET was %s)",
ini_siret[:9],
partner.display_name,
ini_siret,
)
partner.write({"siren": ini_siret[:9]})

Check warning on line 37 in l10n_fr_siret/post_install.py

View check run for this annotation

Codecov / codecov/patch

l10n_fr_siret/post_install.py#L37 

Added line #L37 was not covered by tests
else:
logger.warning(
"Remove SIRET %s on partner %s because checksum is wrong",
partner.siret,
"Remove SIRET %s on partner %s (bad length and/or checksum, "
"doesn't start with valid SIREN)",
ini_siret,
partner.display_name,
)
partner.write({"siret": False})
logger.info("End of data migration of fields siret/siren/nic on res.partner")