-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] mail_partner_forwarding: Migration to 18.0 #21
[18.0][MIG] mail_partner_forwarding: Migration to 18.0 #21
Conversation
Currently translated at 100.0% (6 of 6 strings) Translation: social-17.0/social-17.0-mail_partner_forwarding Translate-URL: https://translation.odoo-community.org/projects/social-17-0/social-17-0-mail_partner_forwarding/it/
Currently translated at 100.0% (6 of 6 strings) Translation: social-17.0/social-17.0-mail_partner_forwarding Translate-URL: https://translation.odoo-community.org/projects/social-17-0/social-17-0-mail_partner_forwarding/es/
e176419
to
3d6d268
Compare
3d6d268
to
5b84c31
Compare
5b84c31
to
deb3600
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR has the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review ok
/ocabot merge nobump |
@hbrunn hi! could you please check this? it seems to be ready to merge. thanks! |
/ocabot merge nobump |
This PR looks fantastic, let's merge it! |
@hbrunn your merge command was aborted due to failed check(s), which you can inspect on this commit of 18.0-ocabot-merge-pr-21-by-hbrunn-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
Hi @hbrunn , hope you're well. Do you know why the merge didn't work? |
because the tests failed, but meanwhile some good person fixed this. So /ocabot merge nobump should work |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at aff3d26. Thanks a lot for contributing to OCA. ❤️ |
No description provided.