Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] mail_partner_forwarding: Migration to 18.0 #21

Merged
merged 17 commits into from
Feb 19, 2025

Conversation

lef-adhoc
Copy link
Contributor

No description provided.

@lef-adhoc lef-adhoc changed the title [18.0][[MIG] mail_partner_forwarding: Migration to 18.0 [18.0][MIG] mail_partner_forwarding: Migration to 18.0 Dec 5, 2024
@lef-adhoc lef-adhoc force-pushed the 18.0-mig-mail_partner_forwarding branch from e176419 to 3d6d268 Compare December 5, 2024 13:16
@lef-adhoc lef-adhoc force-pushed the 18.0-mig-mail_partner_forwarding branch from 3d6d268 to 5b84c31 Compare December 5, 2024 13:38
@lef-adhoc lef-adhoc force-pushed the 18.0-mig-mail_partner_forwarding branch from 5b84c31 to deb3600 Compare December 5, 2024 13:40
Copy link

@ced-adhoc ced-adhoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Copy link

@baf-adhoc baf-adhoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review ok

@hbrunn
Copy link
Member

hbrunn commented Jan 28, 2025

/ocabot merge nobump

@ced-adhoc
Copy link

@hbrunn hi! could you please check this? it seems to be ready to merge. thanks!

@hbrunn
Copy link
Member

hbrunn commented Feb 4, 2025

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-21-by-hbrunn-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 4, 2025
Signed-off-by hbrunn
@OCA-git-bot
Copy link
Contributor

@hbrunn your merge command was aborted due to failed check(s), which you can inspect on this commit of 18.0-ocabot-merge-pr-21-by-hbrunn-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@ced-adhoc
Copy link

Hi @hbrunn , hope you're well. Do you know why the merge didn't work?

@hbrunn
Copy link
Member

hbrunn commented Feb 19, 2025

because the tests failed, but meanwhile some good person fixed this. So

/ocabot merge nobump

should work

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-21-by-hbrunn-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at aff3d26. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit 588c2b0 into OCA:18.0 Feb 19, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants