Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][FIX] mail_debrand: ensure footer is rendered in test #32

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

StefanRijnhart
Copy link
Member

@StefanRijnhart StefanRijnhart commented Feb 12, 2025

See odoo/odoo@9f65f1a

Fixes

2025-02-12 16:01:58,174 254 ERROR odoo odoo.addons.mail_debrand.tests.test_mail_debrand: FAIL: TestMailDebrand.test_default_debrand
Traceback (most recent call last):
  File "/__w/mail/mail/mail_debrand/tests/test_mail_debrand.py", line 52, in test_default_debrand
    self._test_debrand_by_lang(
  File "/__w/mail/mail/mail_debrand/tests/test_mail_debrand.py", line 47, in _test_debrand_by_lang
    self.assertIn(term, body)
AssertionError: 'Powered by' not found in Markup('\n<html>\n<head>\n
... 

@OCA-git-bot
Copy link
Contributor

Hi @pedrobaeza, @joao-p-marques,
some modules you are maintaining are being modified, check this out!

See odoo/odoo@9f65f1a

Fixes
```
2025-02-12 16:01:58,174 254 ERROR odoo odoo.addons.mail_debrand.tests.test_mail_debrand: FAIL: TestMailDebrand.test_default_debrand
Traceback (most recent call last):
  File "/__w/mail/mail/mail_debrand/tests/test_mail_debrand.py", line 52, in test_default_debrand
    self._test_debrand_by_lang(
  File "/__w/mail/mail/mail_debrand/tests/test_mail_debrand.py", line 47, in _test_debrand_by_lang
    self.assertIn(term, body)
AssertionError: 'Powered by' not found in Markup('\n<html>\n<head>\n
...
```
@StefanRijnhart StefanRijnhart force-pushed the 18.0-fix-mail_debrand-tests branch from 01b67fa to ed2ef23 Compare February 12, 2025 16:08
@StefanRijnhart StefanRijnhart changed the title [FIX] mail_debrand: ensure footer is rendered in test [18.0][FIX] mail_debrand: ensure footer is rendered in test Feb 12, 2025
@StefanRijnhart StefanRijnhart added this to the 18.0 milestone Feb 12, 2025
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straight-forward patch:

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-32-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 938f736 into OCA:18.0 Feb 12, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 06dc3af. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants