-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] mail_activity_team: Migration to 18.0 #38
Open
StefanRijnhart
wants to merge
64
commits into
OCA:18.0
Choose a base branch
from
StefanRijnhart:18.0-mig-mail_activity_team
base: 18.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[18.0][MIG] mail_activity_team: Migration to 18.0 #38
StefanRijnhart
wants to merge
64
commits into
OCA:18.0
from
StefanRijnhart:18.0-mig-mail_activity_team
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cf16ae0
to
e43d73b
Compare
Currently translated at 100.0% (24 of 24 strings) Translation: social-13.0/social-13.0-mail_activity_team Translate-URL: https://translation.odoo-community.org/projects/social-13-0/social-13-0-mail_activity_team/it/
When an activity is scheduled due to automatic processes the onchanges won't adapt the proper user team, so we could have a mismatch that provokes an exceptions due to the designed constaints
- If a user is archived but there's an automatic activity, the team check wouldn't locate him. We have to ensure the context. - When the automatic activity gets a user with no team, we should set the team to a void one as well. TT30470
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: social-15.0/social-15.0-mail_activity_team Translate-URL: https://translation.odoo-community.org/projects/social-15-0/social-15-0-mail_activity_team/
If you schedule an activity and you don't force the team as False, errors might araise. For example, on holidays.
Currently translated at 66.6% (22 of 33 strings) Translation: social-16.0/social-16.0-mail_activity_team Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_activity_team/it/
Translated using Weblate (Spanish) Currently translated at 100.0% (33 of 33 strings) Translation: social-16.0/social-16.0-mail_activity_team Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_activity_team/es/
Currently translated at 100.0% (33 of 33 strings) Translation: social-16.0/social-16.0-mail_activity_team Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_activity_team/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: social-16.0/social-16.0-mail_activity_team Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_activity_team/
Taken from the 16.0 branch after the merge of OCA/social#1280 which was picked for the migration of this module for 17.0 in an earlier stage.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: social-17.0/social-17.0-mail_activity_team Translate-URL: https://translation.odoo-community.org/projects/social-17-0/social-17-0-mail_activity_team/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: social-17.0/social-17.0-mail_activity_team Translate-URL: https://translation.odoo-community.org/projects/social-17-0/social-17-0-mail_activity_team/
Currently translated at 100.0% (32 of 32 strings) Translation: social-17.0/social-17.0-mail_activity_team Translate-URL: https://translation.odoo-community.org/projects/social-17-0/social-17-0-mail_activity_team/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: social-17.0/social-17.0-mail_activity_team Translate-URL: https://translation.odoo-community.org/projects/social-17-0/social-17-0-mail_activity_team/
Currently translated at 100.0% (34 of 34 strings) Translation: social-17.0/social-17.0-mail_activity_team Translate-URL: https://translation.odoo-community.org/projects/social-17-0/social-17-0-mail_activity_team/it/
…exists on server actions
3402620
to
f1d6256
Compare
This was referenced Feb 25, 2025
A monkey patch is required on mail.activity's create method to prevent an unboundError (see odoo/odoo#197864). In order to open the team activities (Late/Today/Future) from the systray widget, domain clause mangling is applied in mail.activity.mixin's web_search_read. Includes OCA/social#1469 that was not ported to 17.0 yet. Aligned ir.rule with upstream mail.activity rule wrt. creation (https://github.com/odoo/odoo/blob/b1ffd68e4094d9456dd4ae8f0fa12b50e5ce9d67/addons/mail/security/mail_security.xml#L223-L232). Co-authored-by: Wodran Van de Sande <[email protected]>
f1d6256
to
81e9212
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continued from OCA/social#1555