Add support for top level JsonElement
values
#3166
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
This pull request fixes #3162
Description
The was that we didn't support extracting type name from the
ODataJsonElementValue
for the context URL when writing top-level properties. This PR handles that as follows:Edm.Double
since we can't be use of the numerical type (int32, double, decimal, etc.?) based on the value kind alone.Edm.Untyped
. This can be problematic and needs to be re-evaluated to see if there's a better option.null
, throw an exception by default since top-level nulls are not supported by default, but with the right compatibility flag, we can returnEdm.Null
(TODO: add test for the latter case)Checklist (Uncheck if it is not completed)
Additional work necessary
If documentation update is needed, please add "Docs Needed" label to the issue and provide details about the required document change in the issue.