next/699/20250126/v1 #12480
Merged
next/699/20250126/v1 #12480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 2bcc66d broke logging from plugins: - debug visibility was reduced making it unusable from an external crate - the plugins view of the log level was broken To fix: - make debug pub - minor change to initialization of the log LEVEL as seen by the plugin so its seen by the plugin. I'm not really sure why the previous version wasn't working though, but this one does
Ticket: 7515 It is a sticky buffer mapping to the smtp.helo log field
Ticket: 7517 It is a sticky buffer mapping to the smtp.mail_from log field
Ticket: 7516 It is a sticky buffer mapping to the smtp.rcpt_to[] log field It is a multi-buffer
Issue: 7502 Add a sticky buffer for "ftp.command" for matching on FTP command names.
Issue: 7502 This commit documents the new FTP sticky buffer "ftp.command".
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12480 +/- ##
==========================================
+ Coverage 80.52% 80.55% +0.02%
==========================================
Files 923 925 +2
Lines 259176 259303 +127
==========================================
+ Hits 208708 208886 +178
+ Misses 50468 50417 -51
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
WARNING:
Pipeline 24363 |
|
Information: QA ran without warnings. Pipeline 24367 |
This was referenced Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Staging:
SV_BRANCH=OISF/suricata-verify#2256