Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests aren't passing with GCC 14 #725

Closed
JDBetteridge opened this issue Aug 14, 2024 · 1 comment
Closed

Tests aren't passing with GCC 14 #725

JDBetteridge opened this issue Aug 14, 2024 · 1 comment

Comments

@JDBetteridge
Copy link
Collaborator

The PyOP2 test suite fails with my gcc which is version 14.1.1.

In many places CStringKernels fail to compile with errors like:

/tmp/pyop2-cache-uid1481007/c1/64d3feccd06d55b4a691f067660e65_p2451144.c:29:7: error: passing argument 1 of ‘k’ from incompatible pointer type [-Wincompatible-pointer-types]
   29 |     k(&(t0[0]));
      |       ^~~~~~~~
      |       |
      |       int32_t * {aka int *}
/tmp/pyop2-cache-uid1481007/c1/64d3feccd06d55b4a691f067660e65_p2451144.c:5:27: note: expected ‘int (*)[2]’ but argument is of type ‘int32_t *’ {aka ‘int *’}
    5 |         static void k(int vd[1][2]) {
      |                       ~~~~^~~~~~~~

I think the correct thing to do is go through the test suite and update all of the incompatible CStringKernels (~18 failing tests). I don't think there is a nicer way of handling this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants