Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Function to add actual_range attribute to MVBS #1388

Open
ctuguinay opened this issue Sep 3, 2024 · 0 comments
Open

Function to add actual_range attribute to MVBS #1388

ctuguinay opened this issue Sep 3, 2024 · 0 comments
Labels
feature request
Milestone
v0.9.1

Comments

@ctuguinay
Copy link
Collaborator

In #1380, we decided to remove the actual_range attribute in the compute_MVBS function since assigning the attribute was forcing computation. Once compute_MVBS produces an MVBS dataset whether lazily or fully computed, a standalone function should add actual_range into the attributes of the MVBS dataset.
@ctuguinay ctuguinay added this to the v0.9.1 milestone Sep 3, 2024
@github-project-automation github-project-automation bot moved this to Todo in Echopype Sep 3, 2024
@ctuguinay ctuguinay changed the title Function to Add actual_range Attribute to MVBS Function to add actual_range attribute to MVBS Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request
Projects
Echopype
Status: Todo
Milestone
v0.9.1
Development

No branches or pull requests
1 participant
@ctuguinay