From a3378878ebfd930e4c1ef96a51cf76390c538760 Mon Sep 17 00:00:00 2001 From: Shepherd Date: Thu, 26 Oct 2023 17:20:01 -0400 Subject: [PATCH] Remove detekt --- .github/workflows/ci.yml | 5 ----- OneSignalSDK/build.gradle | 2 -- OneSignalSDK/onesignal/core/build.gradle | 1 - OneSignalSDK/onesignal/in-app-messages/build.gradle | 1 - OneSignalSDK/onesignal/location/build.gradle | 1 - OneSignalSDK/onesignal/notifications/build.gradle | 1 - 6 files changed, 11 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 18e2e22e0b..5880a10486 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -29,11 +29,6 @@ jobs: working-directory: OneSignalSDK run: | ./gradlew ktlintCheck --console=plain - - name: "[Test] Analyzing" - working-directory: OneSignalSDK - continue-on-error: true - run: | - ./gradlew detekt --console=plain - name: "[Test] SDK Unit Tests" working-directory: OneSignalSDK run: | diff --git a/OneSignalSDK/build.gradle b/OneSignalSDK/build.gradle index 4d1510751b..b41f3ee1db 100644 --- a/OneSignalSDK/build.gradle +++ b/OneSignalSDK/build.gradle @@ -17,7 +17,6 @@ buildscript { kotestVersion = '5.5.0' ktlintPluginVersion = '11.3.1' ktlintVersion = '0.48.2' - detektVersion = '1.21.0' junitVersion = '4.13.2' } @@ -34,7 +33,6 @@ buildscript { classpath "com.huawei.agconnect:agcp:$huaweiAgconnectVersion" classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlinVersion" classpath "org.jlleitschuh.gradle:ktlint-gradle:$ktlintPluginVersion" - classpath "io.gitlab.arturbosch.detekt:detekt-gradle-plugin:$detektVersion" } } diff --git a/OneSignalSDK/onesignal/core/build.gradle b/OneSignalSDK/onesignal/core/build.gradle index bd1219c24e..de1f6a60ff 100644 --- a/OneSignalSDK/onesignal/core/build.gradle +++ b/OneSignalSDK/onesignal/core/build.gradle @@ -2,7 +2,6 @@ plugins { id 'com.android.library' id 'kotlin-android' id 'org.jlleitschuh.gradle.ktlint' - id 'io.gitlab.arturbosch.detekt' } android { diff --git a/OneSignalSDK/onesignal/in-app-messages/build.gradle b/OneSignalSDK/onesignal/in-app-messages/build.gradle index 35529ab73a..8e60ebf38a 100644 --- a/OneSignalSDK/onesignal/in-app-messages/build.gradle +++ b/OneSignalSDK/onesignal/in-app-messages/build.gradle @@ -2,7 +2,6 @@ plugins { id 'com.android.library' id 'kotlin-android' id 'org.jlleitschuh.gradle.ktlint' - id 'io.gitlab.arturbosch.detekt' } android { diff --git a/OneSignalSDK/onesignal/location/build.gradle b/OneSignalSDK/onesignal/location/build.gradle index f66be7455e..ca18e76bda 100644 --- a/OneSignalSDK/onesignal/location/build.gradle +++ b/OneSignalSDK/onesignal/location/build.gradle @@ -2,7 +2,6 @@ plugins { id 'com.android.library' id 'kotlin-android' id 'org.jlleitschuh.gradle.ktlint' - id 'io.gitlab.arturbosch.detekt' } android { diff --git a/OneSignalSDK/onesignal/notifications/build.gradle b/OneSignalSDK/onesignal/notifications/build.gradle index 3dd557788c..56aa98c83b 100644 --- a/OneSignalSDK/onesignal/notifications/build.gradle +++ b/OneSignalSDK/onesignal/notifications/build.gradle @@ -2,7 +2,6 @@ plugins { id 'com.android.library' id 'kotlin-android' id 'org.jlleitschuh.gradle.ktlint' - id 'io.gitlab.arturbosch.detekt' } android {