Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly distinguish between Classes and Instances #365

Open
nielstron opened this issue Apr 7, 2024 · 0 comments
Open

Properly distinguish between Classes and Instances #365

nielstron opened this issue Apr 7, 2024 · 0 comments
Labels
bb: major Major issue according to bug bounty categorization bug bounty This issue is prized out as part of the Bug Bounty Program enhancement New feature or request

Comments

@nielstron
Copy link
Contributor

nielstron commented Apr 7, 2024

Is your feature request related to a problem? Please describe.
Currently, OpShin does not distinguish between instances and classes properly. Looking at the type system, every access to an instance type simply gets forwarded to the class that implements it, at this step we loose information about whether the object that had the attribute was a Class or an Instance. Cf the implementation of InstanceType: https://github.com/OpShin/opshin/blob/main/opshin/types.py#L1437.

Describe the solution you'd like
There should be a seperate InstanceType that handles requests differently than the corresponding Class Type (or calls the class and adds the self parameter or sth similar. However unclear how #103 would then work).

Describe alternatives you've considered
None

Bug bounty: 1500 ADA

@nielstron nielstron added bug bounty This issue is prized out as part of the Bug Bounty Program bb: major Major issue according to bug bounty categorization labels Apr 7, 2024
@nielstron nielstron added the enhancement New feature or request label Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bb: major Major issue according to bug bounty categorization bug bounty This issue is prized out as part of the Bug Bounty Program enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant