Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backend] Prevent event loop CPU blocking when processing applyUpdate in container rules (#9936) #9969

Merged
merged 1 commit into from
Feb 17, 2025
Merged

[backend] Prevent event loop CPU blocking when processing applyUpdate in container rules (#9936) #9969

merged 1 commit into from
Feb 17, 2025

Conversation

richard-julien
Copy link
Member

See #9936

@richard-julien richard-julien added the filigran team use to identify PR from the Filigran team label Feb 13, 2025
@richard-julien richard-julien linked an issue Feb 13, 2025 that may be closed by this pull request
Prevent event loop CPU blocking when processing applyUpdate in container rules #9936
Closed
@richard-julien richard-julien self-assigned this Feb 13, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 13, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 64.32%. Comparing base (a0b469b) to head (f73cc18).
Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
...tform/opencti-graphql/src/utils/data-processing.ts 72.22% 5 Missing ⚠️
...ncti-graphql/src/rules/containerWithRefsBuilder.ts 33.33% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #9969   +/-   ##
=======================================
  Coverage   64.31%   64.32%           
=======================================
  Files         655      656    +1     
  Lines       62996    63015   +19     
  Branches     6981     6988    +7     
=======================================
+ Hits        40518    40532   +14     
- Misses      22478    22483    +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lndrtrbn
lndrtrbn reviewed Feb 14, 2025
View reviewed changes
opencti-platform/opencti-graphql/tests/01-unit/utils/data-processing-test.ts
import { asyncFilter } from '../../../src/utils/data-processing';

describe('Data processing tests', () => {
it('Filter processing data', async () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible in the test to mock MAX_EVENT_LOOP_PROCESSING_TIME to 0 to test the function asyncFilter with the Promise being called?

@richard-julien richard-julien merged commit 633fbea into master Feb 17, 2025
9 checks passed
@richard-julien richard-julien deleted the issue/9936 branch February 17, 2025 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lndrtrbn lndrtrbn lndrtrbn left review comments

Assignees

@richard-julien richard-julien

Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prevent event loop CPU blocking when processing applyUpdate in container rules
2 participants
@richard-julien @lndrtrbn