Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backend] Side deletions of ref relationships can lead to updated_at upgrade (#9944) #9968

Merged
merged 2 commits into from
Feb 17, 2025
Merged

[backend] Side deletions of ref relationships can lead to updated_at upgrade (#9944) #9968

merged 2 commits into from
Feb 17, 2025

Conversation

richard-julien
Copy link
Member

See #9944

@richard-julien richard-julien added the filigran team use to identify PR from the Filigran team label Feb 13, 2025
@richard-julien richard-julien self-assigned this Feb 13, 2025
@richard-julien richard-julien linked an issue Feb 13, 2025 that may be closed by this pull request
Side deletions of ref relationships can lead to updated_at upgrade #9944
Closed
@codecov Codecov
Copy link

codecov bot commented Feb 13, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.32%. Comparing base (a0b469b) to head (92a3734).
Report is 15 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #9968   +/-   ##
=======================================
  Coverage   64.31%   64.32%           
=======================================
  Files         655      656    +1     
  Lines       62996    63045   +49     
  Branches     6981     6992   +11     
=======================================
+ Hits        40518    40555   +37     
- Misses      22478    22490   +12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lndrtrbn lndrtrbn self-requested a review February 14, 2025 08:38
@lndrtrbn
Copy link
Member

Does "remove the indicator from the report" should update the updated_at of the report? From what I see in the code of the PR it should, but in my tests it does not

@richard-julien
Copy link
Member Author

Does "remove the indicator from the report" should update the updated_at of the report? From what I see in the code of the PR it should, but in my tests it does not

It should work yes. Thats the target

@richard-julien richard-julien merged commit ab8d177 into master Feb 17, 2025
9 checks passed
@richard-julien richard-julien deleted the issue/9944 branch February 17, 2025 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lndrtrbn lndrtrbn Awaiting requested review from lndrtrbn

Assignees

@richard-julien richard-julien

Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Side deletions of ref relationships can lead to updated_at upgrade
2 participants
@richard-julien @lndrtrbn