Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apache commons update breaks dependency resolution #50

Open
poshul opened this issue Jul 22, 2024 · 6 comments
Open

Apache commons update breaks dependency resolution #50

poshul opened this issue Jul 22, 2024 · 6 comments

Comments

@poshul
Copy link
Contributor

poshul commented Jul 22, 2024

This causes the nightly to break

org.apache.commons.commons-io;bundle-version="[2.15.0,3.0.0)",

With the following error

Error:  Cannot resolve project dependencies:
Error:    Software being installed: de.openms.knime.importers 0.0.1.202407171425
Error:    Missing requirement: de.openms.knime.importers 0.0.1.202407171425 requires 'osgi.bundle; org.apache.commons.commons-io [2.15.0,3.0.0)' but it could not be found
Error:  
Error:  See https://wiki.eclipse.org/Tycho/Dependency_Resolution_Troubleshooting for help.
Error:  Cannot resolve dependencies of MavenProject: de.openms:de.openms.knime.importers:0.0.1.202407171425 @ /home/runner/work/OpenMS/OpenMS/de.openms.knime.importers/.polyglot.META-INF: See log for details -> [Help 1]
Error:  
Error:  To see the full stack trace of the errors, re-run Maven with the -e switch.
Error:  Re-run Maven using the -X switch to enable full debug logging.
Error:  
Error:  For more information about the errors and possible solutions, please read the following articles:
Error:  [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MavenExecutionException
Error: Process completed with exit code 1.

@steffen-fissler @jpfeuffer I've very little understanding of Java dependency resolution, can either of you opine on how to handle this?

@jpfeuffer
Copy link
Contributor

jpfeuffer commented Jul 22, 2024

Against which KNIME version?
AFAIK we depend on KNIME providing the commons to avoid version clashes.

@jpfeuffer
Copy link
Contributor

https://forum.knime.com/t/preview-of-knime-analytics-platform-5-3-0/80588

Someone should subscribe to the community forum or ask Steffen to add you as a maintainer such that you will be added to the community developer mailing list (where changes are announced before the actual release such that you can test the plugin early).

@jpfeuffer
Copy link
Contributor

jpfeuffer commented Jul 22, 2024

You are testing against KNIME 5.1
https://github.com/OpenMS/OpenMS/blob/develop/.github/workflows/openms_ci_matrix_full.yml#L707

The changes in your and Steffens recent PRs were most likely for 5.3

@poshul
Copy link
Contributor Author

poshul commented Jul 22, 2024

Ah, okay. that makes sense. I'm trying to get the GKN to build with 5.3.0, but I get:

!ENTRY org.eclipse.tycho.surefire.junit4 2 0 2024-07-17 13:17:07.948
!MESSAGE Could not resolve module: org.eclipse.tycho.surefire.junit4 [223]
  Unresolved requirement: Import-Package: javax.annotation

@jpfeuffer
Copy link
Contributor

Which Java version is used?

@jpfeuffer
Copy link
Contributor

It works on Jenkins with J17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants