New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to translate OSD popup notifications #45

Open

anadahz opened this issue Mar 21, 2017 · 1 comment

Labels

anadahz commented Mar 21, 2017

Currently the popup OSD notifications are not being displayed to the user's selected language but default to English. Example: Successfully ran test XXX

Tested on https://github.com/TheTorProject/ooni-probe/releases/tag/v2.2.0-rc.2
(ooniprobe-wui version: 2.2.0-rc.4)

The text was updated successfully, but these errors were encountered:

anadahz changed the title ~~Translate OSD popup notifications~~ Add support to translate OSD popup notifications

Contributor

hellais commented Mar 21, 2017

This is very challenging to do, because the text is actually generated inside of ooniprobe itself and is not part of the web UI.

I am not entirely sure what is the best way to tackle this if it is to add mapping for the to be translated strings inside of ooni-wui (where we already have I18N support) or add I18N to ooniprobe itself.

This is anyways going to be something that is going to likely only happen post 2.2.0

hellais added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment