Skip to content
This repository was archived by the owner on Jan 9, 2023. It is now read-only.

OAA PR filter is very hard to read #84

Open
matejak opened this issue Oct 5, 2020 · 0 comments
Open

OAA PR filter is very hard to read #84

matejak opened this issue Oct 5, 2020 · 0 comments

Comments

@matejak
Copy link
Contributor

matejak commented Oct 5, 2020

The OAA PR job configuration uses a matrix build together with a filter.
The filter is really hard to read:

   !(t_branch=="rhel7-branch" && distributions=="fedora")
&& !(t_branch=="master" && distributions=="rhel7")
&& !(t_branch=="rhel8-branch" && distributions=="rhel7")

What about replacing it with something like

   (t_branch=="rhel7-branch" && distributions=="rhel7")
|| (t_branch=="rhel8-branch" && distributions=="rhel8")
|| (t_branch=="master" && distributions=="fedora")

and in case when master is compatible with rhel8 just add that combination to the condition.

Moreover, I think that the first form works only because the rhel8 label is left out from the matrix.
As the second solution looks obviously better, I have a feeling that I may be missing something.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant