-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Notifications #25
Comments
@markusphil i'd like to work on that |
Yeah awesome! 😊 |
Another minor issue: When you create a poll with a lot of questions, the "Please enter a poll title" error message appears outside of the visible area. |
@dkellner, Good point! the notifications should have a fixed position. But I actually like the idea that the noifications stick around even when the user navigates to other pages. Still they should fade out automatically after a few seconds. |
@Twissi I just merged your new pull request! Thanks a lot! :) When you want to continue working on notifications, you could work on allowing multiple messages and removing them automatically. I guess it should integrate easily with what you've build so far 😊 (You'll need to replace the individual |
Right now error or success messeges are only loged to the console but they need to be displayed for the user.
It might be smart to use vuex for managing the message content. I'd also like to use a transition group for smooth animations.
maybe kinda like this package:
https://www.npmjs.com/package/vue-notification
Thanks to @Twissi we now have a great basic solution for displaying notifications, with more improvements to follow😊 We now should used it for all error handling
The text was updated successfully, but these errors were encountered: