Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

speaker kwarg conflicts #8

Open
NeonDaniel opened this issue Mar 27, 2023 · 0 comments
Open

speaker kwarg conflicts #8

NeonDaniel opened this issue Mar 27, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@NeonDaniel
Copy link
Member

The speaker param used in get_tts conflicts with the speaker param used in Neon Audio.

I don't see what speaker provides in this context that is different from voice, but maybe it can be refactored to a different kwarg?

Alternatively/in addition, there should be some type checking implemented to handle invalid kwargs passed to the plugin.
@NeonDaniel NeonDaniel added the bug Something isn't working label Mar 27, 2023
NeonDaniel added a commit that referenced this issue Mar 27, 2023
@NeonDaniel
Patch speaker param checks
9729993 
Relates to #8
@NeonDaniel NeonDaniel mentioned this issue Mar 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NeonDaniel