Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shlcofideleg extension question #3973

Closed
5 tasks done
fly-1011 opened this issue Dec 2, 2024 · 4 comments · Fixed by #3986
Closed
5 tasks done

Shlcofideleg extension question #3973

fly-1011 opened this issue Dec 2, 2024 · 4 comments · Fixed by #3986
Assignees
Labels
question Question requiring answer

Comments

@fly-1011
Copy link

fly-1011 commented Dec 2, 2024

Before start

  • I have read the RISC-V ISA Manual and this is not a RISC-V ISA question. 我已经阅读过 RISC-V 指令集手册,这不是一个指令集相关的问题。
  • I have read the XiangShan Documents. 我已经阅读过香山文档。
  • I have searched the previous issues and did not find anything relevant. 我已经搜索过之前的 issue,并没有找到相关的。
  • I have searched the previous discussions and did not find anything relevant. 我已经搜索过之前的 discussions,并没有找到相关的。
  • I have reviewed the commit messages from the relevant commit history. 我已经浏览过相关的提交历史和提交信息。

Describe the question

Describe:

When using spike as a reference model to test Xiangshan, the following inconsistencies occurred

image
image

The inconsistency is in the 13th bit of the hideleg register. I found the following explanation in the rsicv specification:

Extension Shlcofideleg supports delegating LCOFI interrupts to VS-mode. If the Shlcofideleg
extension is implemented, hideleg bit 13 is writable; otherwise, it is read-only zero. When bit 13 of
hideleg is zero, vsip.LCOFIP and vsie.LCOFIE are read-only zeros. Else, vsip.LCOFIP and vsie.LCOFIE
are aliases of sip.LCOFIP and sie.LCOFIE.

Has Xiangshan achieved the Shlcofideleg expansion? The extension was not found in the following files

def ISAExtensions = Seq(
// single letter extensions, in canonical order
"i", "m", "a", "f", "d", "c", /* "b", */ "v", "h",
// multi-letter extensions, sorted alphanumerically
"sdtrig", "sha", "shcounterenw", "shgatpa", "shtvala", "shvsatpa", "shvstvala", "shvstvecd",
"smaia", "smstateen", "ss1p13", "ssaia", "ssccptr", "sscofpmf", "sscounterenw", "ssstateen",
"sstc", "sstvala", "sstvecd", "ssu64xl", "sv39", "sv48", "svade", "svbare", "svinval",
"svpbmt", "za64rs", "zba", "zbb", "zbc", "zbkb", "zbkc", "zbkx", "zbs", "zcb", "zcmop",
"zfa", "zfh", "zfhmin", "zic64b", "zicbom", "zicbop", "zicboz", "ziccif", "zicclsm",
"ziccrse", "zicntr", "zicond", "zicsr", "zifencei", "zihintpause", "zihpm", "zimop", "zkn",
"zknd", "zkne", "zknh", "zksed", "zksh", "zkt", "zvbb", "zvfh", "zvfhmin", "zvkt",
"zvl128b", "zvl32b", "zvl64b"
)

Environmental Information

xiangshan:commit fcefab3 (HEAD -> master, origin/master, origin/HEAD)
ready-to-run: commit c1dc496545b9d62bb10264cd4485cb6fe7c60798 (HEAD -> master, origin/master, origin/HEAD)

@fly-1011 fly-1011 added the question Question requiring answer label Dec 2, 2024
@Tang-Haojin Tang-Haojin self-assigned this Dec 3, 2024
@Tang-Haojin
Copy link
Member

Thank you for your report. I will handle this.

@Tang-Haojin Tang-Haojin linked a pull request Dec 5, 2024 that will close this issue
@Tang-Haojin
Copy link
Member

XiangShan does implement Shlcofideleg extension, but spike does not support this yet. Waiting for this PR: riscv-software-src/riscv-isa-sim#1847.

@Tang-Haojin
Copy link
Member

We will add corresponding isa string to our parameter.

@fly-1011
Copy link
Author

fly-1011 commented Dec 5, 2024

😊Thank you for your reply and PR submission

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Question requiring answer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants