Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add _mint to erc721 constructor #693

Closed
andrew-fleming opened this issue Aug 10, 2023 · 0 comments · Fixed by #811
Closed

Add _mint to erc721 constructor #693

andrew-fleming opened this issue Aug 10, 2023 · 0 comments · Fixed by #811

Comments

@andrew-fleming
Copy link
Collaborator

Since we're including a constructor in the ERC721 contract (making it a preset of sorts), I think we should be able to at least mint an NFT upon deployment. We follow a similar approach with the ERC20 constructor in setting an initial supply
@andrew-fleming andrew-fleming mentioned this issue Aug 14, 2023
Merged
3 tasks
@martriay martriay moved this to 📋 Backlog in Contracts for Cairo Oct 18, 2023
@martriay martriay mentioned this issue Nov 22, 2023
Merged
3 tasks
@martriay martriay linked a pull request Nov 22, 2023 that will close this issue
Add ERC721 preset #811
Merged
3 tasks
@martriay martriay added this to the current milestone Nov 22, 2023
@martriay martriay moved this from 📋 Backlog to 👀 In review in Contracts for Cairo Nov 22, 2023
@martriay martriay moved this from 👀 In review to ✅ Resolved in Contracts for Cairo Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Contracts for Cairo
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add ERC721 preset andrew-fleming/cairo-contracts
2 participants
@martriay @andrew-fleming