Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mechanism to determine if a task should fail the Sign Up #78

Closed
harveysanders opened this issue Sep 27, 2023 · 0 comments · Fixed by #79
Closed

Add mechanism to determine if a task should fail the Sign Up #78

harveysanders opened this issue Sep 27, 2023 · 0 comments · Fixed by #79

Comments

@harveysanders
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Some tasks that run during the SignUp process should not cause the entire Sign Up to fail
Ex:

Describe the solution you'd like
Add some way to describe a task as required or not. If a task is not required and it fails, the Sign Up will still complete successfully with an OK response.

Describe alternatives you've considered

  • Add a method to the task interface, isRequired() bool that each task can implement. Then the task runner can use this method to determine if the Sign Up request should fail if the task fails.

Additional context

@taylorshephard taylorshephard linked a pull request Sep 27, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant