Fix minor issues

[a-shahba]

Fixed two minor issues in the package

• Dataset.pm declares %PDLtoHDF5fileMapping as a local variable, i.e. my %PDLtoHDF5fileMapping. However, this variable was already declared as a local one to the package (via our statement) at the top of the file. This will cause users' scripts with a shebang like #!/usr/bin/perl -w to print warning messages like

"my" variable %PDLtoHDF5fileMapping masks earlier declaration in same scope at /usr/lib/x86_64-linux-gnu/perl5/5.30/PDL/IO/HDF5/Dataset.pm line 197.

• Package version in Makefile.PL is not consistent with the one in HDF5.pm. Because of this inconsistency when the user installs the package via cpanm (i.e. cpanm PDL::IO::[email protected]), incorrect package version will be embedded in the log message, which is misleading.

--> Working on PDL::IO::HDF5
Fetching http://www.cpan.org/authors/id/E/ET/ETJ/PDL-IO-HDF5-0.76.tar.gz ... OK
Configuring PDL-IO-HDF5-0.73 ... OK
Building and testing PDL-IO-HDF5-0.73 ...
OK
Successfully installed PDL-IO-HDF5-0.73
1 distribution installed

[mohawk2]

Thank you for this! Please could you instead:

• switch the licence to just "the same terms as Perl" (thereby not needing the complicated version stuff there)
• also change the whole version thing from being in $meta_merge to just a WriteMakefile arg VERSION_FROM => 'HDF5.pm'

[mohawk2]

I've allowed the CI, which will fail as PDL now needs 5.14+ so don't worry about that. I'm about to update the CI config, so please rebase this past that.

[a-shahba]

I've allowed the CI, which will fail as PDL now needs 5.14+ so don't worry about that. I'm about to update the CI config, so please rebase this past that.

Implemented the suggested changes and rebased it past your changes to the CI yml file

[mohawk2]

@a-shahba Thanks for accepting those suggestions. I see that you absolutely haven't rebased, but instead merged (a big clue is the word "merge" in one of the new commits). Please could you actually rebase, and force-push?

[a-shahba]

@a-shahba Thanks for accepting those suggestions. I see that you absolutely haven't rebased, but instead merged (a big clue is the word "merge" in one of the new commits). Please could you actually rebase, and force-push?

@mohawk2 I thought it would be enough for this PR to include your latest changes to the YAML file. I will rebase it shortly but I am curious why you prefer rebasing.

I read your comments and hopefully I got your points correctly this time. If not, no worries! Let me know what needs to be modified and I will do it.

[coveralls]

coverage: 72.303%. remained the same
when pulling bdd1e7c on a-shahba:fixMinorIssues
into 3ab50c6 on PDLPorters:master.

[mohawk2]

Thank you for this contribution! I don't know what you actually did, but it wasn't rebasing, because the merge commit was still there. The reason to rebase rather than use merge commits for this situation (working on a topic branch) is shown by what happened here - it's possible to create deeply confusing situations. Somehow your branch had two different copies of your "use HDF5.pm" commit. I fixed it.

A way to check whether a change to a build system in particular is correct, is to do make realclean, then perl Makefile.PL && make test.

[mohawk2]

This has now been released as 0.761.