Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync PRs on orignal repo #3

Open
peter279k opened this issue May 15, 2019 · 7 comments
Open

Sync PRs on orignal repo #3

peter279k opened this issue May 15, 2019 · 7 comments

Comments

@peter279k
Copy link
Collaborator

As title, I create the issue on issue #71 in original repo.

Because original repo seems to be inactive/unmaintained by @ccampbell, I try think about the PR synchronization.

I think we should move all PRs on original repos to this forked repos and keep this forked repos be maintained.

@hopeseekr , What do you think about this?

@hopeseekr
Copy link
Member

Yep, i'm doing it, like right now... I have some questions about some of the PRs, and legitly about 1/3 of the PRs seem to be dupes of one another. Seriously, the 500 on huge chrome buffer is like 3 or 4 of the existing PRs.

@hopeseekr
Copy link
Member

hopeseekr commented May 15, 2019

In chronological order, ascending:

  1. Update ChromePhp.php with debug() [Added default namespace (\) to Reflection* classes ccampbell/chromephp#13]: Won't merge: Unknown utility.
  2. Check HTTP header size [Check HTTP header size ccampbell/chromephp#40]: Addressed in PR HTTPD default 8Kb header limit check, to avoid 500 Internal Server Error #2.
  3. Add a setting for base-path so that only the relevant parts of the file [Add a setting for base-path so that only the relevant parts of the file ... ccampbell/chromephp#42]: Won't merge: Unknown utility, seems to be a non-trivial risk.
  4. _log returns the class instance for method chaining [_log returns the class instance for method chaining ccampbell/chromephp#43]: Merged in PR Okonomiyaki3000: _log returns the class instance for method chaining #43 #4.
  5. use PHP_VERSION and version_compare() where appropriate [use PHP_VERSION and version_compare() where appropriate ccampbell/chromephp#44]: Merged pre-official fork via hopeseekr-contribs/chromephp#2.
  6. Refactor [Refactor ccampbell/chromephp#45]: Won't merge: BIG change. Includes non-trivial risk of number 3.
  7. HTTPD default 8Kb header limit check, to avoid 500 Internal Server Error [HTTPD default 8Kb header limit check, to avoid 500 Internal Server Error ccampbell/chromephp#63]: Merged in PR HTTPD default 8Kb header limit check, to avoid 500 Internal Server Error #2.
  8. properly namespacing reflection classes [properly namespacing reflection classes ccampbell/chromephp#51]: Merged in PR Namespaced the code and brought into full PSR-4 compliance #5.
  9. Prevent Apache 500 internal server error, truncates logs that are too big [Prevent Apache 500 internal server error, truncates logs that are too… ccampbell/chromephp#65]: Addressed in PR HTTPD default 8Kb header limit check, to avoid 500 Internal Server Error #2.
  10. Properly added notification of the Apache 2.0 licensing. [Properly added notification of the Apache 2.0 licensing. ccampbell/chromephp#72]: Merged pre-fork.
  11. Removed support for incredibly dead and buried versions of PHP. [Removed support for incredibly dead and buried versions of PHP.  ccampbell/chromephp#74]: **Merged in PR Removed support for incredibly dead and buried versions of PHP.  #1].

Needs research:
2. Global enable / disable, very basic FirePHP compatibility [ccampbell/chromephp#55]
3. new function: logs an exception to the console [ccampbell/chromephp#68]

@peter279k
Copy link
Collaborator Author

@hopeseekr, thank you for your explanation.

I just note that we have to update PR status on the original repository and it can notify original PR authors.

@hopeseekr
Copy link
Member

You can @ notify them. I think that's what's needed most at this point...

@jsonjuri
Copy link

@hopeseekr can you add this updated repo to packagist? I would like to use it with composer. The original code of ccampbell is outdated and gives issues which are solved in this repo.

@hopeseekr
Copy link
Member

So did I effectively fork this project but forget to publish???

@peter279k
Copy link
Collaborator Author

So did I effectively fork this project but forget to publish???

I don't find this forked package on the packagist.

Perhaps you should check that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants