-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mission to 0.7.1 #43
Comments
Can we have these on the road to 0.8.0 instead of 0.7.1 so we can release small updates faster? |
@gabrielbull I keep it in the current milestone... If it's not finished while other tickets have been closed, I will change the milestone for this one. |
Hi, @Progi1984, Thanks. |
Hi @RomanSyroeshko , I just update the first post for moving tests directory. |
I'm willing to help on the documentation and creating unit tests. I will start with unit tests since I can (almost) figure out what to do. But what about the documentation? How are we going to approach this? By using README like we have now? |
If you want, you can work on unit tests... I'm currently working on the Section directory. So you can work on another directory if you want. |
Unit tests on Template class are reserved by me. :) |
Ok :) I'll start with Style |
Hi @Progi1984 2: Implement unit tests on Travis CI: This is done, right? |
3: Transform the red status in green status on Travis CI We can't, we need to push this one to the 0.8.0 milestone. |
@ivanlanin, @gabrielbull |
|
👍 |
@ivanlanin @gabrielbull I begin the documentation this week... so don't worry ! I will ask you some help for really improving it. |
Ok 👍 |
Guys, could somebody explain to me how to fork from develop branch? I'm in a strange situation now. I dropped my old fork and recreated it from master branch. Then I decided to make some changes in the code. To do that I need actual code, so I made a pull request to pull changes from develop branch into my fork. Then I committed some changes to my fork. I would like to create a PR, but it suggest to merge to PHPWord's develop not only my changes, but merged from develop branch changes too. Should I wait the moment when changes from develop branch will go to master and then try again, or there is another way? |
After forking, clone on your local machine and use the command |
Got it! Thanks a lot, @gabrielbull. |
@Progi1984 Number 4 (test and migrate all samples) done. We can delete samples/old if we want. |
@ivanlanin You can delete it in the PR #122 |
Closed :) |
The text was updated successfully, but these errors were encountered: