Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLNmodels is not compatible with R < 4.1 #124

Closed
fplazaonate opened this issue Apr 4, 2024 · 3 comments · Fixed by #125
Closed

PLNmodels is not compatible with R < 4.1 #124

fplazaonate opened this issue Apr 4, 2024 · 3 comments · Fixed by #125
Assignees

Comments

@fplazaonate
Copy link

Hi @jchiquet ,

I have tried to install PLNmodels from the CRAN but it failed on R 3.6:

Error in parse(outFile) : 
  /tmp/RtmpUSHbgH/R.INSTALL1b016bcc75b7/PLNmodels/R/ZIPLN.R:96:143: '>' inattendu(e)
95:   covariance <- match.arg(covariance)
96:   if (covariance == "fixed") stopifnot("Omega must be provied for fixed covariance" = inherits(Omega, "matrix") | inherits(Omega, "Matrix")) |>

The pipe operator "|>" has been introduced in R 4.1. Contrary to what is stated in the CRAN, this new release is not compatible with R 3.X

@mahendra-mariadassou mahendra-mariadassou self-assigned this Apr 4, 2024
@mahendra-mariadassou
Copy link
Collaborator

Hi @fplaza,

Thanks for catching this, there were two instances of |> that went under my radar when I reviewed the code. A hotfix in the master branch will be up quickly and except this to be fixed in the next release.

@fplazaonate
Copy link
Author

Hi @mahendra-mariadassou
Thanks for the quick reply.
Meanwhile, I have installed the version 1.1.0

@mahendra-mariadassou
Copy link
Collaborator

You can now install the 1.2.1 version with the hotfix from github using

remotes::install_github("pln-team/PLNmodels")

We'll probably wait for slightly more substantial updates before submitting a new release to CRAN

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants