From 9ad8f889629b8f2ea37a8af737749d3e92dc0f95 Mon Sep 17 00:00:00 2001 From: Panos Karabelas Date: Tue, 3 Dec 2024 01:36:42 +0000 Subject: [PATCH] [rendering] fixed tree flickering in the forest world --- editor/Widgets/RenderOptions.cpp | 2 +- runtime/Rendering/Font/Font.cpp | 2 +- runtime/Rendering/Renderer_Passes.cpp | 6 ++++++ 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/editor/Widgets/RenderOptions.cpp b/editor/Widgets/RenderOptions.cpp index ba716705c..a0cf60f85 100644 --- a/editor/Widgets/RenderOptions.cpp +++ b/editor/Widgets/RenderOptions.cpp @@ -315,7 +315,7 @@ void RenderOptions::OnTickVisible() // gi { // toggle - option_check_box("GI - Global illumination (WIP)", Renderer_Option::GlobalIllumination); + option_check_box("GI - Global illumination", Renderer_Option::GlobalIllumination); // internal resolution //float gi_value = Renderer::GetOption(Renderer_Option::GlobalIllumination); diff --git a/runtime/Rendering/Font/Font.cpp b/runtime/Rendering/Font/Font.cpp index 1a583b981..6921950c9 100644 --- a/runtime/Rendering/Font/Font.cpp +++ b/runtime/Rendering/Font/Font.cpp @@ -83,7 +83,7 @@ namespace Spartan void Font::AddText(const string& text, const Vector2& position_screen_percentage) { - // early exit if the renderer isn't ready + // don't accumulate text if the renderer hasn't rendered a frame yet if (Renderer::GetFrameNumber() < 1) return; diff --git a/runtime/Rendering/Renderer_Passes.cpp b/runtime/Rendering/Renderer_Passes.cpp index 0a0726ee9..35373c1f3 100644 --- a/runtime/Rendering/Renderer_Passes.cpp +++ b/runtime/Rendering/Renderer_Passes.cpp @@ -1255,6 +1255,12 @@ namespace Spartan cmd_list->BeginTimeblock(is_transparent_pass ? "light_composition_transparent" : "light_composition"); + // todo: see if this can be done in the shader (to avoid the barrier) + if (is_transparent_pass) + { + cmd_list->ClearTexture(tex_out, Color::standard_transparent); + } + // set pipeline state static RHI_PipelineState pso; pso.name = "light_composition_transparent";