Skip to content
This repository has been archived by the owner on Jan 23, 2018. It is now read-only.

Managing state variables #98

Closed
jvwong opened this issue Jul 5, 2017 · 4 comments
Closed

Managing state variables #98

jvwong opened this issue Jul 5, 2017 · 4 comments

Comments

@jvwong
Copy link
Member

jvwong commented Jul 5, 2017

Many pathway instances have state variables that are ambiguous, distracting and often not very helpful.

e.g. 1 Signaling by BMP displays state variable x[283-396] for the BMP dimer that originates from a 'FragmentFeature' in the corresponding BioPAX. Guessing from Reactome/Unirprot, this may indicate the amino acid region of the mature form originating from a pro-protein (http://www.uniprot.org/uniprot/P12643#ptm_processing).

At best this is distracting and unnecessarily clutters an already busy network. Also the meaning of this information should be more clear to a user / biologist user - or hidden/filtered out.

Also Newt sometimes does not display this information

Example when it doesn't display meaningless state variables:
http%3A%2F%2Fidentifiers.org%2Freactome%2FR-HSA-201451

Example when it does:
http%3A%2F%2Fidentifiers.org%2Freactome%2FR-HSA-6803211

screen shot 2017-07-14 at 12 39 06 pm

I suspect the difference maybe just in how many of these state variables they choose to render.

@jvwong jvwong added this to the View v2.0 milestone Jul 5, 2017
@jvwong jvwong changed the title Ambiguous state variables / fragment features Filtering state variables Jul 5, 2017
@d2fong
Copy link
Member

d2fong commented Jul 5, 2017

Newt does display stuff like x[1-393] sometimes.
Check this one:
http%3A%2F%2Fidentifiers.org%2Freactome%2FR-HSA-6803211

Why they do it sometimes but not always, I don't know.

@jvwong jvwong changed the title Filtering state variables Managing state variables Jul 6, 2017
@jvwong
Copy link
Member Author

jvwong commented Jul 6, 2017

For clarity and complexity management, some of these features (BioPAX parlance) must be displayed as units of information (e.g. phosphorylation) as they communicate important differences in state.

Aside relevant to SBGN-converter: Some state variables have pretty cryptic text. For example, BMP Receptor Signaling from PID(http%3A%2F%2Fpathwaycommons.org%2Fpc2%2FPathway_eb9be568a2c75cb8fad9e5c47f250f20) provides a ModificationFeature 'residue modification, inactive' in BioPAX but the corresponding SBGN-ML state value is 'Ina'?

Remaining could be considered as additional metadata placed in a context menu along with the other stuff (e.g. 'FragmentFeature').

@jvwong
Copy link
Member Author

jvwong commented Jul 21, 2017

@IgorRodchenkov
Copy link
Member

Done in the app-ui repo.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants