diff --git a/src/Thinktecture.EntityFrameworkCore.Relational/Extensions/WindowFunction.cs b/src/Thinktecture.EntityFrameworkCore.Relational/Extensions/WindowFunction.cs index 629ce69b..185385e6 100644 --- a/src/Thinktecture.EntityFrameworkCore.Relational/Extensions/WindowFunction.cs +++ b/src/Thinktecture.EntityFrameworkCore.Relational/Extensions/WindowFunction.cs @@ -30,19 +30,19 @@ public abstract partial class WindowFunction /// /// Indication whether to use '*' when no arguments are provided. /// - public bool UseStarWhenNoArguments { get; } + public bool UseAsteriskWhenNoArguments { get; } /// /// Initializes a new instance of . /// /// The name of the window function. /// Return type of the function. - /// Indication whether to use '*' when no arguments are provided. - protected WindowFunction(string name, Type returnType, bool useStarWhenNoArguments) + /// Indication whether to use '*' when no arguments are provided. + protected WindowFunction(string name, Type returnType, bool useAsteriskWhenNoArguments) { Name = EnsureValidName(name); ReturnType = returnType ?? throw new ArgumentNullException(nameof(returnType)); - UseStarWhenNoArguments = useStarWhenNoArguments; + UseAsteriskWhenNoArguments = useAsteriskWhenNoArguments; } private static string EnsureValidName(string name) @@ -67,12 +67,12 @@ private static string EnsureValidName(string name) /// /// The name of the function. /// The return type of the function. - /// Indication whether to use '*' when no arguments are provided. - public void Deconstruct(out string name, out Type returnType, out bool useStarWhenNoArguments) + /// Indication whether to use '*' when no arguments are provided. + public void Deconstruct(out string name, out Type returnType, out bool useAsteriskWhenNoArguments) { name = Name; returnType = ReturnType; - useStarWhenNoArguments = UseStarWhenNoArguments; + useAsteriskWhenNoArguments = UseAsteriskWhenNoArguments; } } @@ -85,11 +85,11 @@ public sealed class WindowFunction : WindowFunction, IEquatable. /// /// The name of the window function - /// Indication whether to use '*' when no arguments are provided. + /// Indication whether to use '*' when no arguments are provided. public WindowFunction( string name, - bool useStarWhenNoArguments = false) - : base(name, typeof(TResult), useStarWhenNoArguments) + bool useAsteriskWhenNoArguments = false) + : base(name, typeof(TResult), useAsteriskWhenNoArguments) { } diff --git a/src/Thinktecture.EntityFrameworkCore.SqlServer/EntityFrameworkCore/Query/ExpressionTranslators/SqlServerDbFunctionsTranslator.cs b/src/Thinktecture.EntityFrameworkCore.SqlServer/EntityFrameworkCore/Query/ExpressionTranslators/SqlServerDbFunctionsTranslator.cs index 46ca4b26..b3d5cb9c 100644 --- a/src/Thinktecture.EntityFrameworkCore.SqlServer/EntityFrameworkCore/Query/ExpressionTranslators/SqlServerDbFunctionsTranslator.cs +++ b/src/Thinktecture.EntityFrameworkCore.SqlServer/EntityFrameworkCore/Query/ExpressionTranslators/SqlServerDbFunctionsTranslator.cs @@ -71,7 +71,7 @@ internal SqlServerDbFunctionsTranslator( private SqlExpression CreateWindowFunction(IReadOnlyList arguments) { - var (functionName, returnType, useStarWhenNoArguments) = (WindowFunction?)((SqlConstantExpression)arguments[1]).Value + var (functionName, returnType, useAsteriskWhenNoArguments) = (WindowFunction?)((SqlConstantExpression)arguments[1]).Value ?? throw new ArgumentException("Window function must not be null"); var orderByExpression = arguments[^1] as WindowFunctionOrderingsExpression; @@ -101,7 +101,7 @@ private SqlExpression CreateWindowFunction(IReadOnlyList argument var partitionBy = partitionByExpression?.PartitionBy.Select(e => _sqlExpressionFactory.ApplyDefaultTypeMapping(e)).ToList(); return new WindowFunctionExpression(functionName, - useStarWhenNoArguments, + useAsteriskWhenNoArguments, returnType, _typeMappingSource.FindMapping(returnType, _model), functionArgs, diff --git a/src/Thinktecture.EntityFrameworkCore.SqlServer/EntityFrameworkCore/Query/SqlExpressions/WindowFunctionExpression.cs b/src/Thinktecture.EntityFrameworkCore.SqlServer/EntityFrameworkCore/Query/SqlExpressions/WindowFunctionExpression.cs index 39381987..f9e2e0da 100644 --- a/src/Thinktecture.EntityFrameworkCore.SqlServer/EntityFrameworkCore/Query/SqlExpressions/WindowFunctionExpression.cs +++ b/src/Thinktecture.EntityFrameworkCore.SqlServer/EntityFrameworkCore/Query/SqlExpressions/WindowFunctionExpression.cs @@ -15,7 +15,7 @@ public class WindowFunctionExpression : SqlExpression /// Creates a new instance of the class. /// /// Function name. - /// Indication whether to use '*' when no arguments are provided. + /// Indication whether to use '*' when no arguments are provided. /// Return type. /// Arguments. /// Type mapping. @@ -23,7 +23,7 @@ public class WindowFunctionExpression : SqlExpression /// A list of ordering expressions to order by. public WindowFunctionExpression( string name, - bool useStarWhenNoArguments, + bool useAsteriskWhenNoArguments, Type type, RelationalTypeMapping? typeMapping, IReadOnlyList arguments, @@ -32,7 +32,7 @@ public WindowFunctionExpression( : base(type, typeMapping) { Name = name; - UseStarWhenNoArguments = useStarWhenNoArguments; + UseAsteriskWhenNoArguments = useAsteriskWhenNoArguments; Arguments = arguments; Partitions = partitions ?? Array.Empty(); Orderings = orderings ?? Array.Empty(); @@ -46,7 +46,7 @@ public WindowFunctionExpression( /// /// Indication whether to use '*' when no arguments are provided. /// - public bool UseStarWhenNoArguments { get; } + public bool UseAsteriskWhenNoArguments { get; } /// /// Function arguments. @@ -71,7 +71,7 @@ protected override Expression VisitChildren(ExpressionVisitor visitor) var orderings = visitor.VisitExpressions(Orderings); return !ReferenceEquals(arguments, Arguments) || !ReferenceEquals(partitions, Partitions) || !ReferenceEquals(orderings, Orderings) - ? new WindowFunctionExpression(Name, UseStarWhenNoArguments, Type, TypeMapping, arguments, partitions, orderings) + ? new WindowFunctionExpression(Name, UseAsteriskWhenNoArguments, Type, TypeMapping, arguments, partitions, orderings) : this; } @@ -84,7 +84,7 @@ protected override void Print(ExpressionPrinter expressionPrinter) { expressionPrinter.VisitCollection(Arguments); } - else if (UseStarWhenNoArguments) + else if (UseAsteriskWhenNoArguments) { expressionPrinter.Append(" * "); } @@ -118,7 +118,7 @@ private bool Equals(WindowFunctionExpression windowFunctionExpression) { return base.Equals(windowFunctionExpression) && Name.Equals(windowFunctionExpression.Name) - && UseStarWhenNoArguments.Equals(windowFunctionExpression.UseStarWhenNoArguments) + && UseAsteriskWhenNoArguments.Equals(windowFunctionExpression.UseAsteriskWhenNoArguments) && (Arguments == null ? windowFunctionExpression.Arguments == null : Arguments.SequenceEqual(windowFunctionExpression.Arguments)) && (Partitions == null ? windowFunctionExpression.Partitions == null : Partitions.SequenceEqual(windowFunctionExpression.Partitions)) && (Orderings == null ? windowFunctionExpression.Orderings == null : Orderings.SequenceEqual(windowFunctionExpression.Orderings)); @@ -130,7 +130,7 @@ public override int GetHashCode() var hash = new HashCode(); hash.Add(base.GetHashCode()); hash.Add(Name); - hash.Add(UseStarWhenNoArguments); + hash.Add(UseAsteriskWhenNoArguments); foreach (var argument in Arguments) { diff --git a/src/Thinktecture.EntityFrameworkCore.SqlServer/EntityFrameworkCore/Query/ThinktectureSqlServerQuerySqlGenerator.cs b/src/Thinktecture.EntityFrameworkCore.SqlServer/EntityFrameworkCore/Query/ThinktectureSqlServerQuerySqlGenerator.cs index 5aa3e966..ac7bd4f0 100644 --- a/src/Thinktecture.EntityFrameworkCore.SqlServer/EntityFrameworkCore/Query/ThinktectureSqlServerQuerySqlGenerator.cs +++ b/src/Thinktecture.EntityFrameworkCore.SqlServer/EntityFrameworkCore/Query/ThinktectureSqlServerQuerySqlGenerator.cs @@ -50,7 +50,7 @@ private Expression VisitWindowFunction(WindowFunctionExpression windowFunctionEx Visit(argument); } - if (windowFunctionExpression.Arguments.Count == 0 && windowFunctionExpression.UseStarWhenNoArguments) + if (windowFunctionExpression.Arguments.Count == 0 && windowFunctionExpression.UseAsteriskWhenNoArguments) Sql.Append("*"); Sql.Append(") OVER (");