Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.12 support #52

Open
JanneKiiskila opened this issue Sep 30, 2024 · 1 comment
Open

Python 3.12 support #52

JanneKiiskila opened this issue Sep 30, 2024 · 1 comment
Assignees

Comments

@JanneKiiskila
Copy link
Contributor

JanneKiiskila commented Sep 30, 2024

Python 3.12 is not supported now. The code actually works and passes with Python 3.12 (as long as you use pytest 7.4.2), however issues is with pylint. Currently selected version of pylint is not compatible with Python 3.12.

pylint: Command line or configuration file:1: UserWarning: 'BaseException' is not a proper value for the 'overgeneral-exceptions' option. Use fully qualified name (maybe 'builtins.BaseException' ?) instead. This will cease to be checked at runtime when the configuration upgrader is released.
pylint: Command line or configuration file:1: UserWarning: 'Exception' is not a proper value for the 'overgeneral-exceptions' option. Use fully qualified name (maybe 'builtins.Exception' ?) instead. This will cease to be checked at runtime when the configuration upgrader is released.
************* Module manifesttool.package_tool.package_format.tar_package
manifesttool/package_tool/package_format/tar_package.py:69:19: E0606: Possibly using variable 'asn1_dict' before assignment (possibly-used-before-assignment)
************* Module manifesttool.dev_tool.actions.init
manifesttool/dev_tool/actions/init.py:357:0: R0917: Too many positional arguments (6/5) (too-many-positional-arguments)
************* Module manifesttool.dev_tool.actions.create
manifesttool/dev_tool/actions/create.py:207:0: R0917: Too many positional arguments (12/5) (too-many-positional-arguments)
************* Module manifesttool.dev_tool.actions.update
manifesttool/dev_tool/actions/update.py:174:0: R0917: Too many positional arguments (6/5) (too-many-positional-arguments)
manifesttool/dev_tool/actions/update.py:232:0: R0917: Too many positional arguments (17/5) (too-many-positional-arguments)

If you upgrade pylint, you run int a number of issues - which should be either suppressed or fixed. Or if you upgrade to very latest pylint, it will not work with Python 3.8 anymore.

With pytest 8.x the FOTA cases (all of them) will fail.

@JanneKiiskila JanneKiiskila added the wontfix This will not be worked on label Sep 30, 2024
@JanneKiiskila
Copy link
Contributor Author

Turns out this was not that difficult after all, so this could be released if need be. Our internal repository has this now, but we are not in a hurry to release it. Comes out with the next release when it comes (no schedule/plan available as of now).

@JanneKiiskila JanneKiiskila added pending-release and removed wontfix This will not be worked on labels Oct 1, 2024
@JanneKiiskila JanneKiiskila self-assigned this Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant