Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running ./Build test before ./Build might skip package tests #10

Open
plicease opened this issue May 23, 2019 · 0 comments
Open

Running ./Build test before ./Build might skip package tests #10

plicease opened this issue May 23, 2019 · 0 comments

Comments

@plicease
Copy link
Member

plicease commented May 23, 2019

twin% perl Build.PL
+ pkg-config --modversion uPB
Created MYMETA.yml and MYMETA.json
Creating new 'Build' script for 'Alien-uPB' version '0.12'
twin% ./Build test
Use of uninitialized value in string eq at /home/ollisg/opt/perl/5.30.0-RC2/lib/site_perl/5.30.0/Alien/Base/ModuleBuild.pm line 507.
Testing library (if applicable) ... Done
+ pkg-config --modversion uPB
Use of uninitialized value in pattern match (m//) at /home/ollisg/opt/perl/5.30.0-RC2/lib/site_perl/5.30.0/Alien/Base/ModuleBuild/Repository.pm
 line 22.
Downloading File: https://github.com/mbarbon/upb/archive/a99b98f94f3289c50f653e2ab7d87d2416bbb89b.zip ... Done
Extracting Archive ... Done
Building library ... 
+ cd /tmp/Alien-uPB-0.12/_alien/upb-a99b98f94f3289c50f653e2ab7d87d2416bbb89b
+ make default googlepb CXXFLAGS="-std=c++11" USER_CPPFLAGS="-pthread -fPIC" 
...

Note the diagnostic:

Use of uninitialized value in string eq at /home/ollisg/opt/perl/5.30.0-RC2/lib/site_perl/5.30.0/Alien/Base/ModuleBuild.pm line 507.

It's not the normal order of how ./Build and ./Build test are invoked by cpan clients, but it is probably a legal thing to do, and in the very least it should be easy enough to support.

This is a harmless diagnostic for Aliens that do not have package tests (that is execute tests that come with the alienized packages, rather than the perl tests in t), but for Aliens with package tests this is a problem, as the packaged tests will be skipped.

This diagnostic was reported via email by someone saying they saw the diagnostic when running ./Build first, but I wasn't able to reproduce it with the ABMB 1.06.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant