Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

piston::window doesn’t support the transparent attribute #1338

Closed
ticky opened this issue Mar 18, 2020 · 3 comments · Fixed by #1345 or PistonDevelopers/glutin_window#205
Closed
Assignees
Labels

Comments

@ticky
Copy link

ticky commented Mar 18, 2020

I’m attempting to build a floating window whose background is transparent. It looks like the underlying windowing implementation would support this across Windows, Mac and Linux, however, piston doesn’t expose enough of the window attributes from WindowSettings to enable this feature.

The underlying feature seems relatively straightforward to add, presumably by adding a field matching this one to piston::window::WindowSettings and plumbing it through to glutin_window.

Is this functionality which has been deliberately excluded, or would a set of PRs adding this to the requisite components be something you’re interested in?

@bvssvni
Copy link
Member

bvssvni commented Mar 19, 2020

I agree, this window setting should be added. PRs are welcome!

@bvssvni bvssvni added easy and removed discussion labels May 31, 2020
@bvssvni bvssvni self-assigned this May 31, 2020
bvssvni added a commit to bvssvni/piston that referenced this issue May 31, 2020
@gcstr
Copy link

gcstr commented Jan 16, 2021

Although I can see that this setting is now exposed, it doesn't seem to work for me PistonDevelopers/piston_window#288
Is there any other setting required?

@StevenLu2004
Copy link

The PR (PistonDevelopers/piston/pull/1345) doesn't implement the settings for any of the window backends tho. It literally only adds a field to WindowSettings which doesn't even get read in the GlutinWindow::new() source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants