From 711686c7bab69c6c11ce43227ec8909e56225383 Mon Sep 17 00:00:00 2001 From: Mia Bennett Date: Wed, 21 Feb 2024 15:37:07 +0930 Subject: [PATCH] debug(survey): back to `sent IS NOT true` --- spec/survey_invitation_spec.cr | 2 +- src/placeos-models/survey/invitation.cr | 5 +---- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/spec/survey_invitation_spec.cr b/spec/survey_invitation_spec.cr index 9e27d29a..e91b9278 100644 --- a/spec/survey_invitation_spec.cr +++ b/spec/survey_invitation_spec.cr @@ -38,7 +38,7 @@ module PlaceOS::Model surveys.first.id.should eq invitation_one.id end - it "lists invitations with sent != true", focus: true do + it "lists invitations with sent != true" do invitation_one = Generator.invitation(sent: true).save! invitation_two = Generator.invitation(sent: false).save! invitation_three = Generator.invitation(sent: nil).save! diff --git a/src/placeos-models/survey/invitation.cr b/src/placeos-models/survey/invitation.cr index f2b8a351..3b4ac947 100644 --- a/src/placeos-models/survey/invitation.cr +++ b/src/placeos-models/survey/invitation.cr @@ -25,10 +25,7 @@ module PlaceOS::Model query = query.where(survey_id: survey_id) if survey_id # can't use `query.where_not(sent: true)` here due to # sent <> true` not being equivalent to `sent IS NOT true` in PostgreSQL - query = sent ? query.where(sent: true) : query.where("sent IS NOT ?", true) unless sent.nil? - pp "================================================================================" - pp query.to_sql - pp "================================================================================" + query = sent ? query.where(sent: true) : query.where("sent IS NOT true") unless sent.nil? query.to_a end