Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCR duplicates are not removed in the HiC workflow #159

Closed
GallVp opened this issue Oct 21, 2024 · 1 comment · Fixed by #165
Closed

PCR duplicates are not removed in the HiC workflow #159

GallVp opened this issue Oct 21, 2024 · 1 comment · Fixed by #165
Assignees
Labels
bug Something isn't working
Milestone

Comments

@GallVp
Copy link
Member

GallVp commented Oct 21, 2024

Description of the bug

sandblaster is used to mark PCR duplicates and they are removed with samtools view -F parameter. However, the flag setting 2316 does not remove PCR duplicates as per https://broadinstitute.github.io/picard/explain-flags.html. The setting should be switched to 3852 so that reads with following characteristics are removed,

  • read unmapped
  • mate unmapped
  • not primary alignment
  • read fails platform/vendor quality checks
  • read is PCR or optical duplicate
  • supplementary alignment

Command used and terminal output

No response

Relevant files

No response

System information

plant-food-research-open/assemblyqc version 2.1.1

@GallVp GallVp added the bug Something isn't working label Oct 21, 2024
@GallVp GallVp added this to the 2.2.0 milestone Oct 21, 2024
@GallVp GallVp self-assigned this Oct 21, 2024
@GallVp
Copy link
Member Author

GallVp commented Oct 22, 2024

Add parameter hic_samtools_filter_flag and set its default value to 3852.

To make the flag backwards compatible, check for its absence and if absent set the value to 3852.

@GallVp GallVp linked a pull request Oct 25, 2024 that will close this issue
10 tasks
@GallVp GallVp closed this as completed Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant