Skip to content
This repository has been archived by the owner on Jan 16, 2024. It is now read-only.

added basic support for Portuguese (brazil) languages #2331

Merged
merged 8 commits into from
May 22, 2020

Conversation

norbertschuler
Copy link
Collaborator

@norbertschuler norbertschuler commented May 9, 2020

Fixes #2215

This is a first draft for testing on different devices with different languages. I will merge this only if Portuguese translation is >99% done or after I have removed "pt" again and only keep "pt-BR".

To-Do's:

  • add country flag for Portugal and Brazil (exact size of format as German and Spanish)
  • add Google and Apple AppStore banners (exact size of format as German and Spanish)
  • test what happens when Portuguese (Portugal), i.d. pt-PT is chosen instead pt or pt-BR -> pt-PT is falling back to pt
  • copy e-mail templates for pt-BR to backend
  • deactivated pt
  • prepare app stores with resources

@Chiagozie-Udeh

@norbertschuler
Copy link
Collaborator Author

norbertschuler commented May 9, 2020

Bildschirmfoto 2020-05-10 um 13 00 40

@norbertschuler
Copy link
Collaborator Author

Both have to be adapted to our size of height 100px and dynamic width.

@norbertschuler
Copy link
Collaborator Author

Flag can be build from SVG files in treecounter-plattform repository e.g.

  • rsvg-convert -h 512 ../treecounter-platform/public/images/flags/svg/BR.svg -o app/assets/images/flags/brazil.png
  • change the width to 512 pixel and cut a circle of the resulting image
  • optionally optimized image with tinypng.com

Copy link
Collaborator

@Chiagozie-Udeh Chiagozie-Udeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The translation to Pt-Br works well in all the devices I tested.
However, when I switch from one language to the other, it indicates a switch but the language doesn't change on the App. It still retains the language pre-selected earlier.

That is, if I start off in Portuguese Brazil for instance and request a switch to English US, it will show a switch but the language on the App will remain Portuguese Br. Basically, active translation doesn't work yet both for Android and iOS.

May be you can check this and see what the problem is.

@norbertschuler
Copy link
Collaborator Author

norbertschuler commented May 10, 2020

@Chiagozie-Udeh thank you for testing. You’re right, the app demands to be killed and restarted to load another language. Supporting to change the language while running the app demands more work for which I would like to have a new issue: #2336

@norbertschuler
Copy link
Collaborator Author

@Chiagozie-Udeh there was a bug not showing "Portuguese (Brazil)" on the native apps, but only "Portuguese (Portugal)" - please test once more.

Bildschirmfoto 2020-05-11 um 10 18 15

@norbertschuler
Copy link
Collaborator Author

I will merge this only if Portuguese translation is >99% done or after I have removed "pt" again and only keep "pt-BR".

@Chiagozie-Udeh
Copy link
Collaborator

Just tested and I could see Portuguese Brazil on the native App for the devices I checked both for Android and iOS

@norbertschuler norbertschuler marked this pull request as ready for review May 21, 2020 08:41
@norbertschuler
Copy link
Collaborator Author

I will merge this only if Portuguese translation is >99% done or after I have removed "pt" again and only keep "pt-BR".

I deactivated pt for now in this patch. It can easily be reactivated once Portuguese (Portugal) is translated.

@norbertschuler norbertschuler requested a review from sagararyal May 21, 2020 11:16
@sagararyal
Copy link
Member

@norbertschuler I think permission messages still need to be translated; besides that looks good.

@norbertschuler
Copy link
Collaborator Author

@norbertschuler I think permission messages still need to be translated; besides that looks good.

Permission String are already translated, but not yet exported from LingoHub and merged into this PR - we will add them directly to the develop branch: https://translate.lingohub.com/plant-for-the-planet/dashboard/planet-app-(ios-resources)/

# Conflicts:
#	ios/TreecounterApp.xcodeproj/project.pbxproj
@norbertschuler norbertschuler merged commit a72f7ba into develop May 22, 2020
@norbertschuler norbertschuler deleted the feature/portuguese_brazil_support branch May 22, 2020 11:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Portuguese (Brazil) Translation in App and Backend
3 participants