Enabled Rabbit Streams by adding ability to expose additional ports #2234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijusti
reviewed
Feb 3, 2025
embedded-rabbitmq/src/test/resources/bootstrap-stream.properties
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2234 +/- ##
=============================================
+ Coverage 79.89% 79.96% +0.06%
- Complexity 660 663 +3
=============================================
Files 199 199
Lines 3159 3169 +10
Branches 130 132 +2
=============================================
+ Hits 2524 2534 +10
Misses 565 565
Partials 70 70 ☔ View full report in Codecov by Sentry. |
ijusti
approved these changes
Feb 5, 2025
|
Hi @ijusti , thanks for approving. It seems like one of the builds failed, and I don't have permission to re-run it. Can you give it a go? Thanks. |
Tests were failed |
|
They passed this time. I wonder if it was just an issue with the build system. Tests pass locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Adds the property
embedded.rabbitmq.additionalPorts, which allows us to expose arbitrary port. If you enable the RabbitMQ Streams plugin, you can also expose the port 5552 to use for streams tests.This is my first PR with this project. I hope I've followed the conventions.
Closes #2157