-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of filter function #21
Comments
@johartl just for clarifications, would there be cases where we show predictions and sightings at the same time, or it is just one or the other?? Thanks |
In this case you would show sightings for the last hour and predictions for the next 30 minutes. So yes, there can be both :) |
Are you guys still working on this? |
@johartl yes we are working on it. Will let you know soon when its done |
Is this done guys? |
Yes it is done. Only predictions are not there yet, since we havent got the data for it. |
Okay that's great! So I will keep this issue open until the predictions filtering is implemented. |
Your map needs to implement the filter function. Specification from PokemonGoers/Catch-em-all#24
filter({ pokemonIds, sightingsSince, predictionsUntil })
applies filter options to the map.pokemonIds
Array of Pokemon IDs which are shown (applies to predictions and sightings) on the map. Ifnull
show all 151 Pokemon.sightingsSince
Time in seconds for which sightings (includes mobs) in the past are shown. If0
don't show any sightings.predictionsUntil
Time in seconds for which predictions are shown. If0
don't show any predictions.The filter function will make your
updateTimeRange
function obsolete.The text was updated successfully, but these errors were encountered: