Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add axial offset option for creating a volume from a h5 file #36

Open
gschlafly opened this issue Jan 9, 2023 · 2 comments
Open

Add axial offset option for creating a volume from a h5 file #36

gschlafly opened this issue Jan 9, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@gschlafly
Copy link
Member

The function BirefringentVolume.create_dummy_volume contains a parameter to shift the volume axially by a given amount. It would be great if this option were also added to BirefringentVolume.init_from_file. These functions are located in VolumeRaytraceLFM\birefringence_implementations.py.

@gschlafly gschlafly added the enhancement New feature or request label Jan 9, 2023
@pvjosue
Copy link
Collaborator

pvjosue commented Jan 9, 2023

Good idea. We briefly talked about this with Grant.
A more elegant way of doing this would be to create a 'translate', 'rotate', 'scale' functions, such that we can translate not only axially but in any direction, and we could transform and create more complex volumes without overloading the init_from_file function.

If you agree I' can implement these functions :)

@gschlafly
Copy link
Member Author

I agree—much more elegant!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants