Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use radiometry image to mask rays #99

Open
gschlafly opened this issue May 9, 2024 · 2 comments
Open

Use radiometry image to mask rays #99

gschlafly opened this issue May 9, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@gschlafly
Copy link
Member

If a black pixel is inside the aperture region, then it is assumed to have accumulated zero retardance from the voxels it transversed. However, sometimes the pixel is black simply because no light could even reach that pixel in the experimental configuration.
@gschlafly gschlafly added the bug Something isn't working label May 9, 2024
@gschlafly
Copy link
Member Author

Mostly addressed with commit 0eb713f, except there is an issue with supersample != 1 for experimental images when a radiometry path is not provided.

@gschlafly
Copy link
Member Author

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gschlafly