Code

Refactor polynomials#323

Code

Merged

hernanmd merged 42 commits intomasterPolyMathOrg/PolyMath:masterfrom refactor-polynomialsPolyMathOrg/PolyMath:refactor-polynomialsCopy head branch name to clipboardJan 3, 2024

+163-111

Commits

Commits on Dec 25, 2023

• refactor: Extract a method which encapsulates how to calculate the root of a function.

  hemalvarambhia

  committed
  cf05114

  Copy full SHA for cf05114

• refactor: Rename Variable, where we clarified the name by using the full form.

  hemalvarambhia

  committed
  8ebadd3

  Copy full SHA for 8ebadd3

• refactor: use strictlyPositive to hide the type of Number being referred to.

  hemalvarambhia

  committed
  5146d59

  Copy full SHA for 5146d59

• refactor: clarified the name of a category.

  hemalvarambhia

  committed
  c114607

  Copy full SHA for c114607

• refactor - recategorised the multiplication tests in preparation for more tests.

  hemalvarambhia

  committed
  645b5f5

  Copy full SHA for 645b5f5

• test: wrote a test to demonstrate that multiplication is commutative.

  hemalvarambhia

  committed
  43d01c7

  Copy full SHA for 43d01c7

• refactor: made the test a little more generic.

  hemalvarambhia

  committed
  ca6a896

  Copy full SHA for ca6a896

• test: made the example a little more complicated (example derived from Wolfram Alpha).

  hemalvarambhia

  committed
  4ddb4ef

  Copy full SHA for 4ddb4ef

• format: followed arrange, act and assert.

  hemalvarambhia

  committed
  8089cc2

  Copy full SHA for 8089cc2

• refactor: recategorised some tests for addition.

  hemalvarambhia

  committed
  9fd2c1f

  Copy full SHA for 9fd2c1f

• refactor: recategorised more tests for the other binary operations.

  hemalvarambhia

  committed
  4d7ce1a

  Copy full SHA for 4d7ce1a

• refactor: replaced multiple assertions with use of assert: equals: which uses the object's = message.

  hemalvarambhia

  committed
  4a23af2

  Copy full SHA for 4a23af2

• refactor: Rename Variable, where we give objects names similar to those used in mathematics.

  hemalvarambhia

  committed
  f818335

  Copy full SHA for f818335

• refactor: we equate a product with its expected result directly.

  hemalvarambhia

  committed
  2bfcd0e

  Copy full SHA for 2bfcd0e

• refactor: Rename Variable with domain language.

  hemalvarambhia

  committed
  e0c2919

  Copy full SHA for e0c2919

• refactor: used the assert: equals message rather than check each coefficient.

  hemalvarambhia

  committed
  05ba156

  Copy full SHA for 05ba156

Commits on Dec 27, 2023

• refactor: Rename Variable so it reflects the role played by the object.

  hemalvarambhia

  committed
  4b7f888

  Copy full SHA for 4b7f888

• refactor: renamed protocols to make similar code even more similar.

  hemalvarambhia

  committed
  fa9b49d

  Copy full SHA for fa9b49d

• refactor: renamed Protocols to make similar code even more similar.

  hemalvarambhia

  committed
  7e46a25

  Copy full SHA for 7e46a25

• refactor: we can use Polynomial's = message to reduce number of assertions.

  hemalvarambhia

  committed
  4b0e6ce

  Copy full SHA for 4b0e6ce

• refactor: we can use the Polynomial's = method to reduce the number of assertions and make the tests more DSL like.

  hemalvarambhia

  committed
  c56bdc1

  Copy full SHA for c56bdc1

• test: added a missing test to demonstrate that polynomial addition is commutative.

  hemalvarambhia

  committed
  03ae30d

  Copy full SHA for 03ae30d

• refactor: used the assert: equals: message to take advantage of Polynomial's = message.

  hemalvarambhia

  committed
  31baea4

  Copy full SHA for 31baea4

• refactor: extracted temp, renamed a temp to tell a better story.

  hemalvarambhia

  committed
  c76f8f9

  Copy full SHA for c76f8f9

• test: added a comment describing the example the way a mathematician would understand it.

  hemalvarambhia

  committed
  6f02880

  Copy full SHA for 6f02880

• refactor: replaced equating constants with equating polynomials.

  hemalvarambhia

  committed
  26f762c

  Copy full SHA for 26f762c

• refactor: replaced equating coefficients with equating the polynomial.

  hemalvarambhia

  committed
  1d08970

  Copy full SHA for 1d08970

• refactor: extract temp so we can show the computation being tested clearly.

  hemalvarambhia

  committed
  84b6af9

  Copy full SHA for 84b6af9

• refactor: replaced equating coefficients with equating Polynomials.

  hemalvarambhia

  committed
  aaefdcf

  Copy full SHA for aaefdcf

• test: Extract Variable, so that the operation being tested clear.

  hemalvarambhia

  committed
  4ddc12b

  Copy full SHA for 4ddc12b

• refactor: Extract Variable so we can show the operation being tested clearly.

  hemalvarambhia

  committed
  75c2fd8

  Copy full SHA for 75c2fd8

• refactor: Extract Variable so we can demonstrate the operation being tested clearly.

  hemalvarambhia

  committed
  d4fed03

  Copy full SHA for d4fed03

• refactor: replaced assertions on coefficients with a Polynomial.

  hemalvarambhia

  committed
  2ba7c68

  Copy full SHA for 2ba7c68

• refactor: Extract variable so we can make the operation being tested clearer.

  hemalvarambhia

  committed
  8320ec0

  Copy full SHA for 8320ec0

• refactor: extracted the expected coefficients to a local variable to make equating Polynomials simpler.

  hemalvarambhia

  committed
  4b89858

  Copy full SHA for 4b89858

Commits on Dec 28, 2023

• refactor: extracted magic number and integrand to local variables.

  hemalvarambhia

  committed
  63b3779

  Copy full SHA for 63b3779

• refactor: Rename Variable: the polynomial is the integrand.

  hemalvarambhia

  committed
  a3e7f96

  Copy full SHA for a3e7f96

• refactor: reduce the number of assertions by equating polynomials rather than coefficients.

  hemalvarambhia

  committed
  ecb00fc

  Copy full SHA for ecb00fc

Commits on Dec 30, 2023

• documentation: added documentation to demonstrate how a mathematician would integrate a polynomial w.r.t. x.

  hemalvarambhia

  committed
  a286790

  Copy full SHA for a286790

• fix: corrected the documentation.

  hemalvarambhia

  committed
  efb2a87

  Copy full SHA for efb2a87

• fix: added a missing assertion.

  hemalvarambhia

  committed
  eb0a97f

  Copy full SHA for eb0a97f

• refactor: we can use the arbitrary constant in our expected coefficients of the integrated polynomial.

  hemalvarambhia

  committed
  85c2398

  Copy full SHA for 85c2398