Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename BIOMOD_ModelingOptions to bm_ModelingOptions following recent biomod2 package update #104

Open
achubaty opened this issue May 9, 2024 · 2 comments
Assignees

Comments

@achubaty
Copy link
Contributor

achubaty commented May 9, 2024

biomod2 v4.2-5 [2024] renamed BIOMOD_ModelingOptions() to bm_ModelingOptions()

https://github.com/biomodhub/biomod2/releases/tag/v4.2-5

I've made the changes in 9d4aeb9 on the biomod2-updates branch, but since we point to @CeresBarros fork of biomod2 in the package Remotes, we should ensure that forked version has these latest changes -- I believe you had made some tweaks to the package that we likely need to keep using from your fork, unless they have been merged into the upstream version.

@CeresBarros
Copy link
Member

I'm unsure whether my biomod2 fork can be updated easily with the upstream changes. The divergence may be too large. I'll have to look into this eventually, but likely wont have time soon. I doubt anyone will use the LandR functions that are using biomod2. If so speak up here and I'll try to make sure things work.

In the mean time, I suggest reverting to the functions' orginal names (not the one on the current biomod2 release. It;s unlikely that SDM calculations have changed much between biomod2 versions -- that part of the package has been pretty stable

@achubaty
Copy link
Contributor Author

achubaty commented May 9, 2024

the changes are in a separate branch, and don't need to be dealt with right now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants